[GitHub] [kafka] nizhikov edited a comment on pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

[GitBox <gi...@apache.org>]

nizhikov edited a comment on pull request #8731:
URL: https://github.com/apache/kafka/pull/8731#issuecomment-634652827


   I added call of `fix_opts_for_new_jvm` [here](https://github.com/apache/kafka/commit/befd80b38d3ccb1aa0c6d99a899129fd5cf27774#diff-ad7ee04aff5cb79b1478d038d59d4bbeR48).
   
   But `node` variable for `kafka_log4j_appender.py` don't have an attribute 'version'.
   The fix just adds this attribute from the corresponding Kafka version.
   
   ```
     File "/opt/kafka-dev/tests/kafkatest/services/kafka_log4j_appender.py", line 48, in start_cmd
       cmd = fix_opts_for_new_jvm(node)
     File "/opt/kafka-dev/tests/kafkatest/services/kafka/util.py", line 36, in fix_opts_for_new_jvm
       if node.version == LATEST_0_8_2 or node.version == LATEST_0_9 or node.version == LATEST_0_10_0 or node.version == LATEST_0_10_1 or node.version == LATEST_0_10_2 or node.version == LATEST_0_11_0 or node.version == LATEST_1_0:
   AttributeError: 'ClusterNode' object has no attribute 'version'
   ```
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org