[GitHub] [hbase] xcangCRM commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…

[GitBox <gi...@apache.org>]

xcangCRM commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…
URL: https://github.com/apache/hbase/pull/796#discussion_r343837277
 
 

 ##########
 File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java
 ##########
 @@ -35,10 +35,12 @@
 @InterfaceAudience.Private
 public class HFileContext implements HeapSize, Cloneable {
   public static final int FIXED_OVERHEAD = ClassSize.align(ClassSize.OBJECT +
-      // Algorithm, checksumType, encoding, Encryption.Context, hfileName reference
+      // Algorithm, checksumType, encoding, Encryption.Context, hfileName reference,
       5 * ClassSize.REFERENCE + 2 * Bytes.SIZEOF_INT +
       // usesHBaseChecksum, includesMvcc, includesTags and compressTags
-      4 * Bytes.SIZEOF_BOOLEAN + Bytes.SIZEOF_LONG);
+      4 * Bytes.SIZEOF_BOOLEAN + Bytes.SIZEOF_LONG +
+      //byte[] headers for column family and table name
+      2 * ClassSize.ARRAY + 2 * ClassSize.REFERENCE);
 
 Review comment:
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services