You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "TanYuxin-tyx (via GitHub)" <gi...@apache.org> on 2023/04/19 06:30:15 UTC
[GitHub] [flink] TanYuxin-tyx opened a new pull request, #22427: Flink 30815
TanYuxin-tyx opened a new pull request, #22427:
URL: https://github.com/apache/flink/pull/22427
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Migrate BatchAbstractTestBase and BatchTestBase to junit5*
## Brief change log
- *Migrate BatchAbstractTestBase and BatchTestBase to junit5*
## Verifying this change
This change is a test update without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5
Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1524629429
I don't change the TimestampITCase finally, because separating to a new commit will cause the previous commit of `Migrate BatchTestBase to junit5` can not run the test successfully, which does not comply with the principle that every commit can be passed independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5
Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1523290741
@JunRuiLee Thanks for joining the review. Considering that the two base classes have many table-related and Scala-related subclasses, it is indeed necessary to upgrade all the subclasses to JUnit5. However, I don't believe it is appropriate to update all the tests in this PR. Perhaps we should seek input from others to generate more ideas.
@godfreyhe could you please help take a look at this change, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5
Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1537644742
@godfreyhe @JunRuiLee Thanks for helping review the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5
Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1525612113
@godfreyhe Thanks for helping review the change. I have updated the code according to the comments.
I add 3 methods in `BatchAbstractTestBase`, `createTempFolder`, `createTempFile`, `createFileInTempFolder`. The subclasses call the appropriate method when needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5
Posted by "godfreyhe (via GitHub)" <gi...@apache.org>.
godfreyhe closed pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5
URL: https://github.com/apache/flink/pull/22427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a diff in pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5
Posted by "godfreyhe (via GitHub)" <gi...@apache.org>.
godfreyhe commented on code in PR #22427:
URL: https://github.com/apache/flink/pull/22427#discussion_r1178891930
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/LegacyTableSourceITCase.scala:
##########
@@ -347,7 +349,7 @@ class LegacyTableSourceITCase extends BatchTestBase {
|)
""".stripMargin
tEnv.executeSql(ddl)
- val resultPath = TEMPORARY_FOLDER.newFolder().getAbsolutePath
+ val resultPath = TempDirUtils.newFolder(BatchAbstractTestBase.tmpDir).getAbsolutePath
Review Comment:
nit: can you provide an utility method in BatchAbstractTestBase to wrap `TempDirUtils.newFolder(BatchAbstractTestBase.tmpDir)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TanYuxin-tyx commented on pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5
Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1524586407
@JunRuiLee I agree that the sub subclasses migration can be in separate commits.
The reason for migrating some subclasses is that these classes have some problems in the new JUnit5 and can not run successfully. For example, TimestampITCase lacks the `@Before` annotation, which does not affect the JUnit4 test, but it can not run in the new JUnit5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1514201522
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25de4588583a21fad13ec7a8f36a2e7d0b5b1b82",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "25de4588583a21fad13ec7a8f36a2e7d0b5b1b82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 25de4588583a21fad13ec7a8f36a2e7d0b5b1b82 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JunRuiLee commented on pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5
Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.
JunRuiLee commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1524565314
@TanYuxin-tyx Thanks for the explanation and I agree that migrating all the subclasses in one PR is cumbersome and unnecessary. What confuses me is that the title of this PR is "Migrate BatchAbstractTestBase and BatchTestBase to junit5", but the commits also include migration of some subclasses, although not all of them. I am curious why these subclasses were selected for migration. Could you please clarify? Also, I suggest splitting this into different commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org