You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/15 08:18:24 UTC
[GitHub] [incubator-nuttx] Donny9 opened a new pull request #3721: sim/rptun: support multi(>2) core interactive by share memory
Donny9 opened a new pull request #3721:
URL: https://github.com/apache/incubator-nuttx/pull/3721
## Summary
Support multi >2 core interactive by share memory in simulation.
Example of relationships between the three processes:
AP->BP
AP->CP
BP->CP
## Impact
Support multi-core heterogeneous simulation.
## Testing
daily test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3721: sim/rptun: support multi(>2) core interactive by share memory
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3721:
URL: https://github.com/apache/incubator-nuttx/pull/3721#issuecomment-841652753
> This patch depends on #3726 3726 and #3720, please review and merge them firsty .Thank you!
Hi @Donny9 I think you repeated #3726, it should be other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3721: sim/rptun: support multi(>2) core interactive by share memory
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3721:
URL: https://github.com/apache/incubator-nuttx/pull/3721#discussion_r633492118
##########
File path: boards/sim/sim/sim/Kconfig
##########
@@ -10,6 +10,10 @@ config EXAMPLES_TOUCHSCREEN_BGCOLOR
default 0x007b68ee
depends on EXAMPLES_TOUCHSCREEN
+config SIM_RPTUN_MASTER
+ bool "Remote Processor Tunneling Role"
+ depends on RPTUN
Review comment:
Add the default value for this boolean option.
##########
File path: boards/sim/sim/sim/Kconfig
##########
@@ -10,6 +10,10 @@ config EXAMPLES_TOUCHSCREEN_BGCOLOR
default 0x007b68ee
depends on EXAMPLES_TOUCHSCREEN
+config SIM_RPTUN_MASTER
+ bool "Remote Processor Tunneling Role"
+ depends on RPTUN
Review comment:
Add the default value for this boolean config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on pull request #3721: sim/rptun: support multi(>2) core interactive by share memory
Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #3721:
URL: https://github.com/apache/incubator-nuttx/pull/3721#issuecomment-841658519
>
>
> > This patch depends on #3726 3726 and #3720, please review and merge them firsty .Thank you!
>
> Hi @Donny9 I think you repeated #3726, it should be other PR.
I modify this patch base #3726, #3726 is a modification of the original code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3721: sim/rptun: support multi(>2) core interactive by share memory
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3721:
URL: https://github.com/apache/incubator-nuttx/pull/3721#discussion_r633492118
##########
File path: boards/sim/sim/sim/Kconfig
##########
@@ -10,6 +10,10 @@ config EXAMPLES_TOUCHSCREEN_BGCOLOR
default 0x007b68ee
depends on EXAMPLES_TOUCHSCREEN
+config SIM_RPTUN_MASTER
+ bool "Remote Processor Tunneling Role"
+ depends on RPTUN
Review comment:
Add the default value for this boolean option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3721: sim/rptun: support multi(>2) core interactive by share memory
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3721:
URL: https://github.com/apache/incubator-nuttx/pull/3721#discussion_r633492118
##########
File path: boards/sim/sim/sim/Kconfig
##########
@@ -10,6 +10,10 @@ config EXAMPLES_TOUCHSCREEN_BGCOLOR
default 0x007b68ee
depends on EXAMPLES_TOUCHSCREEN
+config SIM_RPTUN_MASTER
+ bool "Remote Processor Tunneling Role"
+ depends on RPTUN
Review comment:
Add the default value for this boolean config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3721: sim/rptun: support multi(>2) core interactive by share memory
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3721:
URL: https://github.com/apache/incubator-nuttx/pull/3721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #3721: sim/rptun: support multi(>2) core interactive by share memory
Posted by GitBox <gi...@apache.org>.
Donny9 commented on a change in pull request #3721:
URL: https://github.com/apache/incubator-nuttx/pull/3721#discussion_r638498374
##########
File path: boards/sim/sim/sim/Kconfig
##########
@@ -10,6 +10,10 @@ config EXAMPLES_TOUCHSCREEN_BGCOLOR
default 0x007b68ee
depends on EXAMPLES_TOUCHSCREEN
+config SIM_RPTUN_MASTER
+ bool "Remote Processor Tunneling Role"
+ depends on RPTUN
Review comment:
> Add the default value for this boolean config.
Done. thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on pull request #3721: sim/rptun: support multi(>2) core interactive by share memory
Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #3721:
URL: https://github.com/apache/incubator-nuttx/pull/3721#issuecomment-841651730
This patch depends on #3726 3726 and #3720, please review and merge them firsty .Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org