You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Liam Sargent via Review Board <no...@reviews.apache.org> on 2018/02/02 19:31:58 UTC
Review Request 65487: Bump com.codahale.metrics package to
io.dropwizard.metrics version 3.2.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65487/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Steve Moist, and Sergio Pena.
Bugs: SENTRY-2136
https://issues.apache.org/jira/browse/SENTRY-2136
Repository: sentry
Description
-------
Bump com.codahale.metrics package to io.dropwizard.metrics version 3.2.2
Diffs
-----
pom.xml 6f9856e45b72ef9e0c43a222eddc8452b64f1a71
sentry-provider/sentry-provider-db/pom.xml 5733445af481fd83bb71189178647af234fe77a1
sentry-tests/sentry-tests-solr/pom.xml 5ef7a2b1de67a2f35510ad41c0150ad1bc957118
Diff: https://reviews.apache.org/r/65487/diff/1/
Testing
-------
mvn test - ALL PASS
Thanks,
Liam Sargent
Re: Review Request 65487: Bump com.codahale.metrics package to
io.dropwizard.metrics version 3.2.2
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
> On Feb. 8, 2018, 4:13 p.m., Sergio Pena wrote:
> > Ship It!
Thanks Liam for the patch. I checked that there were no more codehale jars included in the classpath (+1), and that other components, such as Hive, uses the new dropwizard library instead of codehale. So, it makes sense to make this change on Sentry as well.
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65487/#review197090
-----------------------------------------------------------
On Feb. 2, 2018, 7:31 p.m., Liam Sargent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65487/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 7:31 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2136
> https://issues.apache.org/jira/browse/SENTRY-2136
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump com.codahale.metrics package to io.dropwizard.metrics version 3.2.2
>
>
> Diffs
> -----
>
> pom.xml 6f9856e45b72ef9e0c43a222eddc8452b64f1a71
> sentry-provider/sentry-provider-db/pom.xml 5733445af481fd83bb71189178647af234fe77a1
> sentry-tests/sentry-tests-solr/pom.xml 5ef7a2b1de67a2f35510ad41c0150ad1bc957118
>
>
> Diff: https://reviews.apache.org/r/65487/diff/1/
>
>
> Testing
> -------
>
> mvn test - ALL PASS
>
>
> Thanks,
>
> Liam Sargent
>
>
Re: Review Request 65487: Bump com.codahale.metrics package to
io.dropwizard.metrics version 3.2.2
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65487/#review197090
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Feb. 2, 2018, 7:31 p.m., Liam Sargent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65487/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 7:31 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2136
> https://issues.apache.org/jira/browse/SENTRY-2136
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump com.codahale.metrics package to io.dropwizard.metrics version 3.2.2
>
>
> Diffs
> -----
>
> pom.xml 6f9856e45b72ef9e0c43a222eddc8452b64f1a71
> sentry-provider/sentry-provider-db/pom.xml 5733445af481fd83bb71189178647af234fe77a1
> sentry-tests/sentry-tests-solr/pom.xml 5ef7a2b1de67a2f35510ad41c0150ad1bc957118
>
>
> Diff: https://reviews.apache.org/r/65487/diff/1/
>
>
> Testing
> -------
>
> mvn test - ALL PASS
>
>
> Thanks,
>
> Liam Sargent
>
>
Re: Review Request 65487: Bump com.codahale.metrics package to
io.dropwizard.metrics version 3.2.2
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65487/#review196726
-----------------------------------------------------------
Ship it!
Ship It!
- Steve Moist
On Feb. 2, 2018, 7:31 p.m., Liam Sargent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65487/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 7:31 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2136
> https://issues.apache.org/jira/browse/SENTRY-2136
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump com.codahale.metrics package to io.dropwizard.metrics version 3.2.2
>
>
> Diffs
> -----
>
> pom.xml 6f9856e45b72ef9e0c43a222eddc8452b64f1a71
> sentry-provider/sentry-provider-db/pom.xml 5733445af481fd83bb71189178647af234fe77a1
> sentry-tests/sentry-tests-solr/pom.xml 5ef7a2b1de67a2f35510ad41c0150ad1bc957118
>
>
> Diff: https://reviews.apache.org/r/65487/diff/1/
>
>
> Testing
> -------
>
> mvn test - ALL PASS
>
>
> Thanks,
>
> Liam Sargent
>
>
Re: Review Request 65487: Bump com.codahale.metrics package to
io.dropwizard.metrics version 3.2.2
Posted by Xinran Tinney <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65487/#review196918
-----------------------------------------------------------
IT is better to put SENTRY-[num] at the beginning of the title
- Xinran Tinney
On Feb. 2, 2018, 7:31 p.m., Liam Sargent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65487/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 7:31 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2136
> https://issues.apache.org/jira/browse/SENTRY-2136
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump com.codahale.metrics package to io.dropwizard.metrics version 3.2.2
>
>
> Diffs
> -----
>
> pom.xml 6f9856e45b72ef9e0c43a222eddc8452b64f1a71
> sentry-provider/sentry-provider-db/pom.xml 5733445af481fd83bb71189178647af234fe77a1
> sentry-tests/sentry-tests-solr/pom.xml 5ef7a2b1de67a2f35510ad41c0150ad1bc957118
>
>
> Diff: https://reviews.apache.org/r/65487/diff/1/
>
>
> Testing
> -------
>
> mvn test - ALL PASS
>
>
> Thanks,
>
> Liam Sargent
>
>
Re: Review Request 65487: Bump com.codahale.metrics package to
io.dropwizard.metrics version 3.2.2
Posted by Xinran Tinney <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65487/#review196917
-----------------------------------------------------------
Ship it!
Ship It!
- Xinran Tinney
On Feb. 2, 2018, 7:31 p.m., Liam Sargent wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65487/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 7:31 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Steve Moist, and Sergio Pena.
>
>
> Bugs: SENTRY-2136
> https://issues.apache.org/jira/browse/SENTRY-2136
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump com.codahale.metrics package to io.dropwizard.metrics version 3.2.2
>
>
> Diffs
> -----
>
> pom.xml 6f9856e45b72ef9e0c43a222eddc8452b64f1a71
> sentry-provider/sentry-provider-db/pom.xml 5733445af481fd83bb71189178647af234fe77a1
> sentry-tests/sentry-tests-solr/pom.xml 5ef7a2b1de67a2f35510ad41c0150ad1bc957118
>
>
> Diff: https://reviews.apache.org/r/65487/diff/1/
>
>
> Testing
> -------
>
> mvn test - ALL PASS
>
>
> Thanks,
>
> Liam Sargent
>
>