You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/04/09 00:24:34 UTC

[GitHub] [nifi] alopresto commented on issue #3340: NIFI-6026 - First commit which adds a new tls-toolkit mode called Key…

alopresto commented on issue #3340: NIFI-6026 - First commit which adds a new tls-toolkit mode called Key…
URL: https://github.com/apache/nifi/pull/3340#issuecomment-481055148
 
 
   I ran through a series of manual tests on the toolkit mode. I like the functionality, and it works with both keystore formats. I made some comments requesting some unit test improvements and the removal of the "single hyphen" long argument in the CLI invocation. Once those are done, I will +1 and merge. Thanks. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services