You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/23 14:18:36 UTC
[GitHub] [skywalking-python] kezhenxu94 opened a new pull request #173: Minimize `exclude` in lint
kezhenxu94 opened a new pull request #173:
URL: https://github.com/apache/skywalking-python/pull/173
@Superskyyy just found that we have `skywalking/agent/protocol` that also contains `protocol` but it should be checked, but our submodule should ideally be also checked in their own repo so I just remove the `protocol` from exclude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #173: Minimize `exclude` in lint
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #173:
URL: https://github.com/apache/skywalking-python/pull/173#issuecomment-950180213
> @Superskyyy just found that we have `skywalking/agent/protocol` that also contains `protocol` but it should be checked, but our submodule should ideally be also checked in their own repo so I just remove the `protocol` from exclude
Ha! I never noticed this one before. I will sync the protocol later to remove the header-checker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng merged pull request #173: Minimize `exclude` in lint
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #173:
URL: https://github.com/apache/skywalking-python/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org