You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/06/02 18:25:57 UTC

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18585


Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................

IMPALA-9718: Delete pkg_resources from impala-shell

This reverts commit 0a0001e1a85462c81c9c4617a2e864c98913f229 to re-apply
IMPALA-9718. CentOS 7 has pkg_resources available in its latest Python
2.7 release; we may need to install python-setuptools if not present in
test environments.

Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
---
M LICENSE.txt
M shell/make_shell_tarball.sh
D shell/pkg_resources.py
3 files changed, 0 insertions(+), 2,702 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/18585/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10688/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 18:45:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10822/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Jun 2022 17:37:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 3:

New run started at https://master-03.jenkins.cloudera.com/job/impala-private-parameterized/1080/.


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Jun 2022 16:33:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18585/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18585/1//COMMIT_MSG@10
PS1, Line 10: CentOS 7 has pkg_resources available in its latest Python
            : 2.7 release
Did you run manu test on CentOS 7?


http://gerrit.cloudera.org:8080/#/c/18585/1//COMMIT_MSG@11
PS1, Line 11: we may need to install python-setuptools if not present
setuptools is included in shell/packaging/requirements.txt.



-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 04:29:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 1:

Running https://master-03.jenkins.cloudera.com/job/impala-private-parameterized/1047/


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 21:18:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 5:

New build with PYTHON_EGG_CACHE correctly exported in impala-shell: https://master-03.jenkins.cloudera.com/job/impala-private-parameterized/1090/


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 17:09:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 6:

Latest private run passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 17:55:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10808/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 20:41:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 20:18:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 03:14:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 4:

> Patch Set 3:
> 
> Running https://master-03.jenkins.cloudera.com/job/impala-private-parameterized/ with PYTHON_EGG_CACHE override.

Specifically https://master-03.jenkins.cloudera.com/job/impala-private-parameterized/1088


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 20:22:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 2: Code-Review+1

I can give +2 once it pass impala-private-parameterized on CentOS.


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jun 2022 23:17:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10813/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 17:26:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18585

to look at the new patch set (#4).

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................

IMPALA-9718: Delete pkg_resources from impala-shell

This reverts commit 0a0001e1a85462c81c9c4617a2e864c98913f229 to re-apply
IMPALA-9718. CentOS 7 has pkg_resources available in its latest Python
2.7 release; we may need to install python-setuptools if not present in
test environments.

Also provides an isolated PYTHON_EGG_CACHE to avoid polution from the
general dev/test environment and specifically address
> UserWarning: /var/lib/jenkins/.python-eggs is writable by group/others
  and vulnerable to attack when used with get_resource_filename.

Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
---
M LICENSE.txt
M bin/impala-config.sh
M shell/make_shell_tarball.sh
D shell/pkg_resources.py
4 files changed, 3 insertions(+), 2,702 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/18585/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> New run started at https://master-03.jenkins.cloudera.com/job/impala-private-parameterized/1080/.

Found 4 tests that still fail due to the warning. So I think the right move is to fix the permissions on ~/.python-eggs. Trying to reproduce locally.


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Jun 2022 16:51:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 3:

Running https://master-03.jenkins.cloudera.com/job/impala-private-parameterized/ with PYTHON_EGG_CACHE override.


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 20:21:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8260/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 17:55:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 6:

(1 comment)

Failure is an instance of https://issues.apache.org/jira/browse/IMPALA-11160. Re-running.

http://gerrit.cloudera.org:8080/#/c/18585/6/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/18585/6/bin/impala-config.sh@365
PS6, Line 365: mkdir -p "${PYTHON_EGG_CACHE}"
Making changes to the system here is unprecedented for this file, but it's a directory we completely own and the steps are idempotent, so I think it's ok.



-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 22:35:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8260/


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 22:32:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18585/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18585/1//COMMIT_MSG@10
PS1, Line 10: CentOS 7 has pkg_resources available in its latest Python
            : 2.7 release
> I haven't, I figured the dryrun would be the easiest way to test that. I kn
impala-private-parameterized (https://master-03.jenkins.cloudera.com/job/impala-private-parameterized/) use CentOS.



-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 18:00:55 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8262/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 22:36:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Jun 2022 21:13:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 6:

https://master-03.jenkins.cloudera.com/job/impala-private-parameterized/1091/


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Jun 2022 17:18:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18585/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18585/1//COMMIT_MSG@10
PS1, Line 10: CentOS 7 has pkg_resources available in its latest Python
            : 2.7 release
> Did you run manu test on CentOS 7?
I haven't, I figured the dryrun would be the easiest way to test that. I know our bootstrap_system script installs python-setuptools, but that's been there for years so I'm not quite sure what environment caused this to be previously reverted.



-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jun 2022 15:34:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18585

to look at the new patch set (#5).

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................

IMPALA-9718: Delete pkg_resources from impala-shell

This reverts commit 0a0001e1a85462c81c9c4617a2e864c98913f229 to re-apply
IMPALA-9718. CentOS 7 has pkg_resources available in its latest Python
2.7 release; we may need to install python-setuptools if not present in
test environments.

Actually uses PYTHON_EGG_CACHE set in the impala-shell script. This has
an extra benefit of avoiding putting PYTHON_EGG_CACHE in the Jenkins
user environment, which is group-writable and causes
> UserWarning: /var/lib/jenkins/.python-eggs is writable by group/others
  and vulnerable to attack when used with get_resource_filename.

Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
---
M LICENSE.txt
M shell/impala-shell
M shell/make_shell_tarball.sh
D shell/pkg_resources.py
4 files changed, 1 insertion(+), 2,703 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/18585/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18585

to look at the new patch set (#6).

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................

IMPALA-9718: Delete pkg_resources from impala-shell

This reverts commit 0a0001e1a85462c81c9c4617a2e864c98913f229 to re-apply
IMPALA-9718. CentOS 7 has pkg_resources available in its latest Python
2.7 release; we may need to install python-setuptools if not present in
test environments.

Also provides an isolated PYTHON_EGG_CACHE to avoid polution from the
general dev/test environment and specifically address
> UserWarning: /var/lib/jenkins/.python-eggs is writable by group/others
  and vulnerable to attack when used with get_resource_filename.

Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
---
M LICENSE.txt
M bin/impala-config.sh
M shell/make_shell_tarball.sh
D shell/pkg_resources.py
4 files changed, 6 insertions(+), 2,702 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/18585/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................

IMPALA-9718: Delete pkg_resources from impala-shell

This reverts commit 0a0001e1a85462c81c9c4617a2e864c98913f229 to re-apply
IMPALA-9718. CentOS 7 has pkg_resources available in its latest Python
2.7 release; we may need to install python-setuptools if not present in
test environments.

Also provides an isolated PYTHON_EGG_CACHE to avoid polution from the
general dev/test environment and specifically address
> UserWarning: /var/lib/jenkins/.python-eggs is writable by group/others
  and vulnerable to attack when used with get_resource_filename.

Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Reviewed-on: http://gerrit.cloudera.org:8080/18585
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M LICENSE.txt
M bin/impala-config.sh
M shell/make_shell_tarball.sh
D shell/pkg_resources.py
4 files changed, 6 insertions(+), 2,702 deletions(-)

Approvals:
  Wenzhe Zhou: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 1:

The errors around checking python version will become a non-issue with https://gerrit.cloudera.org/c/18586/.


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jun 2022 00:44:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9718: Delete pkg resources from impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18585 )

Change subject: IMPALA-9718: Delete pkg_resources from impala-shell
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8237/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e443d78671d8afab70d784664e71a70ccfcd587
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Jun 2022 16:33:44 +0000
Gerrit-HasComments: No