You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/10/18 20:33:19 UTC
[GitHub] storm pull request #2378: STORM-2706: Upgrade to Curator 4.0.0
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2378
STORM-2706: Upgrade to Curator 4.0.0
https://issues.apache.org/jira/browse/STORM-2706
I've tested this with storm-starter running on a distributed mode single-node cluster. I attempted to use storm-perf to see if there was a performance difference, but metrics seem broken on Windows. Might try it out on a Linux box.
I'm hoping people will try this out so we can decide if we want to upgrade.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2706
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2378
----
----
---
[GitHub] storm issue #2378: STORM-2706: Upgrade to Curator 4.0.0
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2378
The simplest way to know for sure what you are going to get is to run `mvn dependency:tree`
```
$ mvn dependency:tree | grep zookeeper | sort -u
[INFO] +- org.apache.zookeeper:zookeeper:jar:3.4.6:compile
[INFO] | +- org.apache.zookeeper:zookeeper:jar:3.4.6:compile
[INFO] | +- org.apache.zookeeper:zookeeper:jar:3.4.6:compile
[INFO] | +- org.apache.zookeeper:zookeeper:jar:3.4.6:provided
[INFO] | +- org.apache.zookeeper:zookeeper:jar:3.4.6:test
[INFO] | \- org.apache.zookeeper:zookeeper:jar:3.4.6:compile
[INFO] | | +- org.apache.zookeeper:zookeeper:jar:3.4.6:provided
```
I did a diff of the dependency trees both before and after this patch. They are identical except for the version of curator has changed.
I am +1 for this change
---
[GitHub] storm issue #2378: STORM-2706: Upgrade to Curator 4.0.0
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2378
According to https://curator.apache.org/zk-compatibility.html, Curator 4.0.x supports both ZK versions, but we still need to keep an eye of ZK version. If we want to support Zookeeper 3.4.x, we need to **exclude** Zookeeper dependency from `curator-recipes` and add Zookeeper dependency manually.
Does the patch work with Zookeeper 3.4.x? We still need to consider supporting Zookeeper 3.4.x first, cause Zookeeper 3.5.x is still announced as 'beta' and most of our end users don't want to explore the beta in production.
---
[GitHub] storm issue #2378: STORM-2706: Upgrade to Curator 4.0.0
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2378
@revans2 Thanks for making it clear. I'm also +1 then.
---
[GitHub] storm pull request #2378: STORM-2706: Upgrade to Curator 4.0.0
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2378
---
[GitHub] storm issue #2378: STORM-2706: Upgrade to Curator 4.0.0
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2378
@HeartSaVioR The exclusion isn't necessary because we set Zookeeper to version 3.4.6 in the dependencyManagement section of the root pom. It ensures that if any child poms depend on Zookeeper without specifying a version they'll get 3.4.6, and if Zookeeper is included transitively it'll also be version 3.4.6.
---