You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/05 09:53:23 UTC

[GitHub] [pulsar] lordcheng10 opened a new pull request #14568: fix npe for getLength in class of EntryImpl

lordcheng10 opened a new pull request #14568:
URL: https://github.com/apache/pulsar/pull/14568


   ### Motivation
   In pulsar broker logs, npe errors were found：
   00:46:15.817 [BookKeeperClientWorker-OrderedExecutor-45-0] ERROR org.apache.bookkeeper.common.util.SafeRunnable - Unexpected throwable caught
   java.lang.NullPointerException: null
           at org.apache.bookkeeper.mledger.impl.EntryImpl.getLength(EntryImpl.java:133) ~[org.apache.pulsar-managed-ledger-2.8.1.2.jar:2.8.1.2]
           at org.apache.bookkeeper.mledger.util.RangeCache.put(RangeCache.java:78) ~[org.apache.pulsar-managed-ledger-2.8.1.2.jar:2.8.1.2]
           at org.apache.bookkeeper.mledger.impl.EntryCacheImpl.insert(EntryCacheImpl.java:114) ~[org.apache.pulsar-managed-ledger-2.8.1.2.jar:2.8.1.2]
           at org.apache.bookkeeper.mledger.impl.OpAddEntry.safeRun(OpAddEntry.java:198) ~[org.apache.pulsar-managed-ledger-2.8.1.2.jar:2.8.1.2]
           at org.apache.bookkeeper.common.util.SafeRunnable.run(SafeRunnable.java:36) [org.apache.bookkeeper-bookkeeper-common-4.14.2.1.jar:4.14.2.1]
           at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_144]
           at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_144]
           at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [io.netty-netty-common-4.1.66.Final.jar:4.1.66.Final]
           at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]
   
   
   ### Modifications
   Make a non-null judgment on data in the method getLength
   
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] `no-need-doc` 
     
     (Please explain why)
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lordcheng10 closed pull request #14568: fix npe for getLength in class of EntryImpl

Posted by GitBox <gi...@apache.org>.
lordcheng10 closed pull request #14568:
URL: https://github.com/apache/pulsar/pull/14568


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #14568: fix npe for getLength in class of EntryImpl

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14568:
URL: https://github.com/apache/pulsar/pull/14568#issuecomment-1059738345


   Hi @lordcheng10, there is a discussion here https://github.com/apache/pulsar/issues/10433 for this issue. I don't think this PR will resolve the problem, it only makes the NPE will be hidden, but I think the entry recycled problem is not fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lordcheng10 commented on pull request #14568: fix npe for getLength in class of EntryImpl

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #14568:
URL: https://github.com/apache/pulsar/pull/14568#issuecomment-1059740044


   > 
   
   OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org