You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "vtlim (via GitHub)" <gi...@apache.org> on 2023/05/15 22:40:49 UTC
[GitHub] [druid] vtlim commented on a diff in pull request #14283: Fixup data deletion tutorial docs
vtlim commented on code in PR #14283:
URL: https://github.com/apache/druid/pull/14283#discussion_r1194316906
##########
docs/operations/api-reference.md:
##########
@@ -293,10 +293,10 @@ Returns full segment metadata for a specific segment in the cluster.
Return the tiers that a datasource exists in.
-#### Note for coordinator's POST and DELETE API's
-The segments would be enabled when these API's are called, but then can be disabled again by the coordinator if any dropRule matches. Segments enabled by these API's might not be loaded by historical processes if no loadRule matches. If an indexing or kill task runs at the same time as these API's are invoked, the behavior is undefined. Some segments might be killed and others might be enabled. It's also possible that all segments might be disabled but at the same time, the indexing task is able to read data from those segments and succeed.
+#### Note for coordinator's POST and DELETE APIs
Review Comment:
```suggestion
#### Note for Coordinator's POST and DELETE APIs
```
##########
docs/operations/api-reference.md:
##########
@@ -293,10 +293,10 @@ Returns full segment metadata for a specific segment in the cluster.
Return the tiers that a datasource exists in.
-#### Note for coordinator's POST and DELETE API's
-The segments would be enabled when these API's are called, but then can be disabled again by the coordinator if any dropRule matches. Segments enabled by these API's might not be loaded by historical processes if no loadRule matches. If an indexing or kill task runs at the same time as these API's are invoked, the behavior is undefined. Some segments might be killed and others might be enabled. It's also possible that all segments might be disabled but at the same time, the indexing task is able to read data from those segments and succeed.
+#### Note for coordinator's POST and DELETE APIs
+The segments would be enabled when these APIs are called, but then can be disabled again by the coordinator if any dropRule matches. Segments enabled by these APIs might not be loaded by historical processes if no loadRule matches. If an indexing or kill task runs at the same time as these APIs are invoked, the behavior is undefined. Some segments might be killed and others might be enabled. It's also possible that all segments might be disabled but at the same time, the indexing task is able to read data from those segments and succeed.
Review Comment:
Wonder if we can update this paragraph while we're at it. If my understanding is correct, perhaps something like the following:
```suggestion
While segments may be enabled by issuing POST requests for the datasources, the Coordinator may again disable segments if they match any configured [drop rules](../operations/rule-configuration.md#drop-rules). Even if segments are enabled by these APIs, you must configure a [load rule](../operations/rule-configuration.md#load-rules) to load them onto Historical processes. If an indexing or kill task runs at the same time these APIs are invoked, the behavior is undefined. Some segments might be killed and others might be enabled. It's also possible that all segments might be disabled, but the indexing task can still read data from those segments and succeed.
```
Not sure if enabled is the same thing as marking a segment as used, and if the DELETE APIs have anything to do with enabling a segment.
##########
docs/operations/api-reference.md:
##########
@@ -293,10 +293,10 @@ Returns full segment metadata for a specific segment in the cluster.
Return the tiers that a datasource exists in.
-#### Note for coordinator's POST and DELETE API's
-The segments would be enabled when these API's are called, but then can be disabled again by the coordinator if any dropRule matches. Segments enabled by these API's might not be loaded by historical processes if no loadRule matches. If an indexing or kill task runs at the same time as these API's are invoked, the behavior is undefined. Some segments might be killed and others might be enabled. It's also possible that all segments might be disabled but at the same time, the indexing task is able to read data from those segments and succeed.
+#### Note for coordinator's POST and DELETE APIs
+The segments would be enabled when these APIs are called, but then can be disabled again by the coordinator if any dropRule matches. Segments enabled by these APIs might not be loaded by historical processes if no loadRule matches. If an indexing or kill task runs at the same time as these APIs are invoked, the behavior is undefined. Some segments might be killed and others might be enabled. It's also possible that all segments might be disabled but at the same time, the indexing task is able to read data from those segments and succeed.
-> Caution : Avoid using indexing or kill tasks and these API's at the same time for the same datasource and time chunk. (It's fine if the time chunks or datasource don't overlap)
+> Caution : Avoid using indexing or kill tasks and these APIs at the same time for the same datasource and time chunk. (It's OK to use them if the time chunks or datasource don't overlap)
Review Comment:
We can remove the `Caution` label since this is already in a note block
```suggestion
> Avoid using indexing or kill tasks and these APIs at the same time for the same datasource and time chunk.
```
##########
docs/tutorials/tutorial-delete-data.md:
##########
@@ -165,16 +153,29 @@ A Kill Task spec has been provided at `quickstart/tutorial/deletion-kill.json`.
curl -X 'POST' -H 'Content-Type:application/json' -d @quickstart/tutorial/deletion-kill.json http://localhost:8081/druid/indexer/v1/task
```
-After this task completes, you can see that the disabled segments have now been removed from deep storage:
+Once this task is finished, you will observe that the disabled segments, specifically segments for hours 18, 19, 22, and 23 have been successfully deleted from deep storage.
Review Comment:
The segments for hours 22-23 have been mentioned a few times already, but where did the segments for hours 18-19 get disabled?
```suggestion
When the task finishes, note that Druid deleted the disabled segments from deep storage.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org