You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/06/25 08:41:36 UTC
Change in asterixdb[master]: ASTERIXDB-1501: add units for timings
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/960
Change subject: ASTERIXDB-1501: add units for timings
......................................................................
ASTERIXDB-1501: add units for timings
Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
2 files changed, 63 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/60/960/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 35a780b..08ff165 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -246,9 +246,9 @@
pw.print(ResultFields.metrics.name());
pw.print("\": {\n");
pw.print("\t");
- printField(pw, Metrics.elapsedTime.name(), String.valueOf(elapsedTime));
+ printField(pw, Metrics.elapsedTime.name(), formatTime(elapsedTime));
pw.print("\t");
- printField(pw, Metrics.executionTime.name(), String.valueOf(executionTime));
+ printField(pw, Metrics.executionTime.name(), formatTime(executionTime));
pw.print("\t");
printField(pw, Metrics.resultCount.name(), String.valueOf(resultCount));
pw.print("\t");
@@ -256,6 +256,25 @@
pw.print("\t}\n");
}
+ static String formatTime(long nanoTime) {
+ final String strTime = String.valueOf(nanoTime);
+ final int len = strTime.length();
+ if (len > 9) {
+ return toUnit(strTime, len - 9, "s");
+ }
+ if (len > 6) {
+ return toUnit(strTime, len - 6, "ms");
+ }
+ if (len > 3) {
+ return toUnit(strTime, len - 3, "�s");
+ }
+ return strTime + "ns";
+ }
+
+ static String toUnit(String strTime, int split, String unit) {
+ return strTime.substring(0, split) + "." + strTime.substring(split) + unit;
+ }
+
@Override
protected void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
new file mode 100644
index 0000000..0b4ae62
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.asterix.api.http.servlet;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class QueryServiceServletTest {
+
+ @Test
+ public void testFormatTime() throws Exception {
+ Assert.assertEquals(QueryServiceServlet.formatTime(123456789012l), "123.456789012s");
+ Assert.assertEquals(QueryServiceServlet.formatTime(12345678901l), "12.345678901s");
+ Assert.assertEquals(QueryServiceServlet.formatTime(1234567890l), "1.234567890s");
+ Assert.assertEquals(QueryServiceServlet.formatTime(123456789l), "123.456789ms");
+ Assert.assertEquals(QueryServiceServlet.formatTime(12345678l), "12.345678ms");
+ Assert.assertEquals(QueryServiceServlet.formatTime(1234567l), "1.234567ms");
+ Assert.assertEquals(QueryServiceServlet.formatTime(123456l), "123.456�s");
+ Assert.assertEquals(QueryServiceServlet.formatTime(12345l), "12.345�s");
+ Assert.assertEquals(QueryServiceServlet.formatTime(1234l), "1.234�s");
+ Assert.assertEquals(QueryServiceServlet.formatTime(123l), "123ns");
+ Assert.assertEquals(QueryServiceServlet.formatTime(12l), "12ns");
+ Assert.assertEquals(QueryServiceServlet.formatTime(1l), "1ns");
+ }
+}
--
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Change in asterixdb[master]: ASTERIXDB-1501: add units for timings
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has submitted this change and it was merged.
Change subject: ASTERIXDB-1501: add units for timings
......................................................................
ASTERIXDB-1501: add units for timings
Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Reviewed-on: https://asterix-gerrit.ics.uci.edu/960
Reviewed-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Yingyi Bu <bu...@gmail.com>
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
2 files changed, 75 insertions(+), 2 deletions(-)
Approvals:
Yingyi Bu: Looks good to me, approved
Jenkins: Looks good to me, but someone else must approve; Verified
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 35a780b..a080c83 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -125,6 +125,34 @@
resultSize
}
+ public enum TimeUnit {
+ SEC("s", 9),
+ MILLI("ms", 6),
+ MICRO("�s", 3),
+ NANO("ns", 0);
+
+ String unit;
+ int nanoDigits;
+
+ TimeUnit(String unit, int nanoDigits) {
+ this.unit = unit;
+ this.nanoDigits = nanoDigits;
+ }
+
+ static String formatNanos(long nanoTime) {
+ final String strTime = String.valueOf(nanoTime);
+ final int len = strTime.length();
+ for (TimeUnit tu : TimeUnit.values()) {
+ if (len > tu.nanoDigits) {
+ final String integer = strTime.substring(0, len - tu.nanoDigits);
+ final String fractional = strTime.substring(len - tu.nanoDigits);
+ return integer + (fractional.length() > 0 ? "." + fractional : "") + tu.unit;
+ }
+ }
+ return "illegal string value: " + strTime;
+ }
+ }
+
private final ILangCompilationProvider compilationProvider = new SqlppCompilationProvider();
static SessionConfig.OutputFormat getFormat(HttpServletRequest request) {
@@ -246,9 +274,9 @@
pw.print(ResultFields.metrics.name());
pw.print("\": {\n");
pw.print("\t");
- printField(pw, Metrics.elapsedTime.name(), String.valueOf(elapsedTime));
+ printField(pw, Metrics.elapsedTime.name(), TimeUnit.formatNanos(elapsedTime));
pw.print("\t");
- printField(pw, Metrics.executionTime.name(), String.valueOf(executionTime));
+ printField(pw, Metrics.executionTime.name(), TimeUnit.formatNanos(executionTime));
pw.print("\t");
printField(pw, Metrics.resultCount.name(), String.valueOf(resultCount));
pw.print("\t");
diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
new file mode 100644
index 0000000..f4889a0
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.asterix.api.http.servlet;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class QueryServiceServletTest {
+
+ @Test
+ public void testTimeUnitFormatNanos() throws Exception {
+ Assert.assertEquals("123.456789012s", QueryServiceServlet.TimeUnit.formatNanos(123456789012l));
+ Assert.assertEquals("12.345678901s", QueryServiceServlet.TimeUnit.formatNanos(12345678901l));
+ Assert.assertEquals("1.234567890s", QueryServiceServlet.TimeUnit.formatNanos(1234567890l));
+ Assert.assertEquals("123.456789ms", QueryServiceServlet.TimeUnit.formatNanos(123456789l));
+ Assert.assertEquals("12.345678ms", QueryServiceServlet.TimeUnit.formatNanos(12345678l));
+ Assert.assertEquals("1.234567ms", QueryServiceServlet.TimeUnit.formatNanos(1234567l));
+ Assert.assertEquals("123.456�s", QueryServiceServlet.TimeUnit.formatNanos(123456l));
+ Assert.assertEquals("12.345�s", QueryServiceServlet.TimeUnit.formatNanos(12345l));
+ Assert.assertEquals("1.234�s", QueryServiceServlet.TimeUnit.formatNanos(1234l));
+ Assert.assertEquals("123ns", QueryServiceServlet.TimeUnit.formatNanos(123l));
+ Assert.assertEquals("12ns", QueryServiceServlet.TimeUnit.formatNanos(12l));
+ Assert.assertEquals("1ns", QueryServiceServlet.TimeUnit.formatNanos(1l));
+ Assert.assertEquals("-123.456789012s", QueryServiceServlet.TimeUnit.formatNanos(-123456789012l));
+ Assert.assertEquals("120.000000000s", QueryServiceServlet.TimeUnit.formatNanos(120000000000l));
+ Assert.assertEquals("-12ns", QueryServiceServlet.TimeUnit.formatNanos(-12l));
+ }
+}
--
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1501: add units for timings
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1501: add units for timings
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1743/
--
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1501: add units for timings
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1501: add units for timings
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1744/
--
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1501: add units for timings
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/960
to look at the new patch set (#4).
Change subject: ASTERIXDB-1501: add units for timings
......................................................................
ASTERIXDB-1501: add units for timings
Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
2 files changed, 75 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/60/960/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: ASTERIXDB-1501: add units for timings
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/960
to look at the new patch set (#2).
Change subject: ASTERIXDB-1501: add units for timings
......................................................................
ASTERIXDB-1501: add units for timings
Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
2 files changed, 76 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/60/960/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: ASTERIXDB-1501: add units for timings
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1501: add units for timings
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1742/
--
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1501: add units for timings
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1501: add units for timings
......................................................................
Patch Set 4:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1745/
--
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1501: add units for timings
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.
Change subject: ASTERIXDB-1501: add units for timings
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1501: add units for timings
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/960
to look at the new patch set (#3).
Change subject: ASTERIXDB-1501: add units for timings
......................................................................
ASTERIXDB-1501: add units for timings
Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
2 files changed, 74 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/60/960/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>