You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/21 11:55:12 UTC
[GitHub] [superset] fullergalway opened a new pull request, #22177: Proposal: allow time_range x-filter from timeseries Echarts (WIP)
fullergalway opened a new pull request, #22177:
URL: https://github.com/apache/superset/pull/22177
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
It would be nice to use the zoom feature on Timeseries Echarts to apply a time_range x-filter
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [X] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [X] Introduces new feature or API
- [ ] Removes existing feature or API
Some issues arise:
1. How to invoke setDataMask in a way that will include the current chart, when that is not the default option for this chart. (In the example displayed I edited the dashboard properties to allow this chart to receive it's own filter) Or otherwise how not to lose the zoom in the timeseries.
2. How to allow drilling down from two timeseries charts so that the second drill down + filter cancels the first filter from the original chart (Or maybe it doesn't matter because it will always be more specific).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] fullergalway closed pull request #22177: feat: proposal allow time_range x-filter from timeseries Echarts (WIP)
Posted by GitBox <gi...@apache.org>.
fullergalway closed pull request #22177: feat: proposal allow time_range x-filter from timeseries Echarts (WIP)
URL: https://github.com/apache/superset/pull/22177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org