You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Abhishek Kadam <ab...@gmail.com> on 2018/06/22 10:28:50 UTC

Review Request 67701: ATLAS-2764: Time Bound classification : Few timezones throw "Invalid timezone exception"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67701/
-----------------------------------------------------------

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Repository: atlas


Description
-------

Folllowing timezones from UI are missing in java timezone and throw INVALID timezone exception
America/Punta_Arenas
Asia/Atyrau
Asia/Famagusta
Asia/Yangon
Europe/Saratov
ROC
It would be good to load timezone TimeZone.getAvailableIDs() on UI.


Diffs
-----

  dashboardv2/public/js/views/tag/AddTimezoneItemView.js 3deab83 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 5012d51 


Diff: https://reviews.apache.org/r/67701/diff/1/


Testing
-------

sanity testing done to check timezone list in dropdown


Thanks,

Abhishek Kadam


Re: Review Request 67701: ATLAS-2764: Time Bound classification : Few timezones throw "Invalid timezone exception"

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67701/#review205233
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On June 22, 2018, 10:28 a.m., Abhishek Kadam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67701/
> -----------------------------------------------------------
> 
> (Updated June 22, 2018, 10:28 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Folllowing timezones from UI are missing in java timezone and throw INVALID timezone exception
> America/Punta_Arenas
> Asia/Atyrau
> Asia/Famagusta
> Asia/Yangon
> Europe/Saratov
> ROC
> It would be good to load timezone TimeZone.getAvailableIDs() on UI.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/tag/AddTimezoneItemView.js 3deab83 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 5012d51 
> 
> 
> Diff: https://reviews.apache.org/r/67701/diff/1/
> 
> 
> Testing
> -------
> 
> sanity testing done to check timezone list in dropdown
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>