You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/16 07:07:21 UTC
[GitHub] [dubbo-go] win5do opened a new issue #1460: 建议重构 dubbo grpc protobuf 代码生成工具与社区保持一致
win5do opened a new issue #1460:
URL: https://github.com/apache/dubbo-go/issues/1460
<!-- Please only use this template for submitting enhancement requests -->
**What would you like to be added**:
https://github.com/apache/dubbo-go/blob/f192c1eaf847fdd38f3cda3d73dea6b02d0654b5/protocol/grpc/protoc-gen-dubbo/plugin/dubbo/dubbo.go#L28
```
// Deprecated: Use the "google.golang.org/protobuf/compiler/protogen" package
// instead to write protoc plugins in Go.
```
dubbo-go 源码引用的 github.com/golang/protobuf 已经被标记为弃用。plugin 生成 grpc 的方式已经不被支持，相关 [issue](https://github.com/golang/protobuf/issues/1070)。
建议参考 [grpc-go](https://github.com/grpc/grpc-go/blob/938f6e2f7550e542bd78f3b9e8812665db109e02/cmd/protoc-gen-go-grpc/main.go) 的方式，重构 protoc-gen-go-dubbo。
使用 [grpc 官方文档](https://grpc.io/docs/languages/go/quickstart/#regenerate-grpc-code)的风格生成代码：
```sh
protoc --go_out=. --go_opt=paths=source_relative \
--go-grpc_out=. --go-grpc_opt=paths=source_relative \
--go-dubbo_out=. --go-dubbo_opt=paths=source_relative \
helloworld.proto
```
**Why is this needed**:
跟 protobuf 社区保持一致，让 dubbo-go 中使用 protobuf 更顺滑。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin closed issue #1460: 建议重构 dubbo grpc protobuf 代码生成工具与社区保持一致
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin closed issue #1460:
URL: https://github.com/apache/dubbo-go/issues/1460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on issue #1460: 建议重构 dubbo grpc protobuf 代码生成工具与社区保持一致
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on issue #1460:
URL: https://github.com/apache/dubbo-go/issues/1460#issuecomment-957530258
@win5do 请加入钉钉群 23331795 和我们一起讨论这个问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on issue #1460: 建议重构 dubbo grpc protobuf 代码生成工具与社区保持一致
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on issue #1460:
URL: https://github.com/apache/dubbo-go/issues/1460#issuecomment-978869409
经过跟领导协商，原生 grpc 将不作为主要支持的协议。建议直接使用与grpc 完全兼容的 triple 协议。 @win5do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on issue #1460: 建议重构 dubbo grpc protobuf 代码生成工具与社区保持一致
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on issue #1460:
URL: https://github.com/apache/dubbo-go/issues/1460#issuecomment-957530258
@win5do 请加入钉钉群 23331795 和我们一起讨论这个问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin edited a comment on issue #1460: 建议重构 dubbo grpc protobuf 代码生成工具与社区保持一致
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin edited a comment on issue #1460:
URL: https://github.com/apache/dubbo-go/issues/1460#issuecomment-978869409
经过跟领导协商，原生 grpc 将不作为主要支持的协议。建议直接使用与grpc 完全兼容的 triple 协议。如果您有时间，期待您可以提交pr羞服务这一问题 @win5do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on issue #1460: 建议重构 dubbo grpc protobuf 代码生成工具与社区保持一致
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on issue #1460:
URL: https://github.com/apache/dubbo-go/issues/1460#issuecomment-957530258
@win5do 请加入钉钉群 23331795 和我们一起讨论这个问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org