You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "andreinnanu (via GitHub)" <gi...@apache.org> on 2026/10/02 18:38:20 UTC

Re: [I] Fix the 3 ignored tests covering a refused consumer-offset write [iggy]

andreinnanu commented on issue #4140:
URL: https://github.com/apache/iggy/issues/4140#issuecomment-5958910743

   Current status:
   
   I stopped a refused offset write (disk full or quota exceeded) to latch the WAL, but other errors are still latching it.
   It can be checked here: https://github.com/apache/iggy/compare/master...andreinnanu:iggy:fix/4140-consumer-offset-wal-latch
   
   I rewrote the two tests, because fail_operation only receives an io::Error and can't tell a refused write from a failed sync. Now tests are covering the following scenarios:
   	- `given_a_full_disk_when_the_offset_write_is_refused_then_persistence_should_not_fence`
   	- `given_a_full_disk_when_the_offset_write_is_refused_then_driving_persistence_should_not_raise_fatal_commit`
   
   But, a full disk still stops the node. When the offset write fails, `handle_committed_entries` sets FatalCommit, and the shard shuts down.
   How would you like to continue? Do we want to fix this flow within this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org