You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "moomman (via GitHub)" <gi...@apache.org> on 2023/05/10 10:48:58 UTC
[GitHub] [shardingsphere-on-cloud] moomman opened a new pull request, #358: feat(operator): add-pressure-exec replace job(get pod log)
moomman opened a new pull request, #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358
### Type of change:
- [x] Bugfix
- [x] New feature provided
- [ ] Improve performance
### What this PR does / why we need it:
1. add pressureCfg spec for pressure-exec
2. change status Msg to express steady And chaos experiment
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545301710
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545300949
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545382756
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1547150580
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545415684
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545406459
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545409362
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1547152563
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1541916821
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545374335
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1541931956
## [Codecov](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#358](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b3061f2) into [main](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/commit/6c3683b3cc842c2652b457a2ca682fcb61f69fc0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c3683b) will **decrease** coverage by `4.74%`.
> The diff coverage is `12.05%`.
```diff
@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 45.74% 41.01% -4.74%
==========================================
Files 47 44 -3
Lines 5032 4850 -182
==========================================
- Hits 2302 1989 -313
- Misses 2561 2708 +147
+ Partials 169 153 -16
```
| [Impacted Files](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ator/cmd/shardingsphere-operator/manager/option.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvY21kL3NoYXJkaW5nc3BoZXJlLW9wZXJhdG9yL21hbmFnZXIvb3B0aW9uLmdv) | `46.42% <0.00%> (-0.42%)` | :arrow_down: |
| [...pkg/controllers/shardingsphere\_chaos\_controller.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL3NoYXJkaW5nc3BoZXJlX2NoYW9zX2NvbnRyb2xsZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [...e-operator/pkg/reconcile/storagenode/aws/aurora.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9zdG9yYWdlbm9kZS9hd3MvYXVyb3JhLmdv) | `0.00% <0.00%> (ø)` | |
| [...here-operator/pkg/reconcile/storagenode/aws/aws.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9zdG9yYWdlbm9kZS9hd3MvYXdzLmdv) | `0.00% <ø> (ø)` | |
| [...perator/pkg/controllers/storage\_node\_controller.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL3N0b3JhZ2Vfbm9kZV9jb250cm9sbGVyLmdv) | `40.65% <17.75%> (-27.37%)` | :arrow_down: |
| [...rator/pkg/reconcile/storagenode/aws/rdsinstance.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9zdG9yYWdlbm9kZS9hd3MvcmRzaW5zdGFuY2UuZ28=) | `22.46% <26.76%> (+6.46%)` | :arrow_up: |
| [pitr/cli/pkg/httputils/req.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl0ci9jbGkvcGtnL2h0dHB1dGlscy9yZXEuZ28=) | `21.91% <69.23%> (ø)` | |
... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/358/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1542127368
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545380494
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545502046
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore merged pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore merged PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on a diff in pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "Xu-Wentao (via GitHub)" <gi...@apache.org>.
Xu-Wentao commented on code in PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#discussion_r1193304769
##########
shardingsphere-operator/pkg/pressure/pressure_test.go:
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package pressure
+
+import (
+ "bou.ke/monkey"
+ "context"
+ "database/sql"
+ "github.com/DATA-DOG/go-sqlmock"
+ "github.com/apache/shardingsphere-on-cloud/shardingsphere-operator/api/v1alpha1"
+ "github.com/stretchr/testify/assert"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+ "regexp"
+ "testing"
+ "time"
+)
+
+func TestRun(t *testing.T) {
Review Comment:
use `ginkgo` and `omega` replace of `testing` and `assert`
##########
shardingsphere-operator/pkg/pressure/pressure.go:
##########
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package pressure
+
+import (
+ "context"
+ "database/sql"
+ "fmt"
+ "sync"
+ "time"
+
+ "github.com/apache/shardingsphere-on-cloud/shardingsphere-operator/api/v1alpha1"
+ _ "github.com/go-sql-driver/mysql"
+)
+
+type Pressure struct {
+ Active bool
+ Name string
+ Result Result
+ Err error
+ Tasks []v1alpha1.DistSQL
+ finishSignalCh chan struct{}
+ wg sync.WaitGroup
+}
+
+var (
+ db *sql.DB
+ totalReq int
+)
+
+type Result struct {
+ //total exec req Number
+ Total int
+ //total success req Number
+ Success int
+ //todo: get total or get every exec
+
+ //total time in this Pressure execution
+ Duration time.Duration
+}
+
+func NewPressure(name string, tasks []v1alpha1.DistSQL) *Pressure {
+ return &Pressure{
+ Active: false,
+ Name: name,
+ Result: Result{},
+ Err: nil,
+ Tasks: tasks,
+ wg: sync.WaitGroup{},
+ finishSignalCh: make(chan struct{}),
+ }
+}
+
+// todo: get conn args by labels over string
+func initDB(connArgs string) error {
+ var err error
+ db, err = sql.Open("mysql", connArgs)
+ if err != nil {
+ return err
+ }
+ if err := db.Ping(); err != nil {
+ return err
+ }
+ db.SetConnMaxLifetime(60 * time.Second)
+ return nil
+}
+
+func (p *Pressure) Run(ctx context.Context, pressureCfg *v1alpha1.PressureCfg) {
+ p.Active = true
+ totalReq = 0
+
+ if db == nil {
+ if err := initDB(pressureCfg.SsHost); err != nil {
+ p.Err = err
+ return
+ }
+ defer func() {
+ if err := db.Close(); err != nil {
+ p.Err = err
+ }
+ }()
+ }
+
+ result := &p.Result
+ pressureCtx, cancel := context.WithTimeout(context.Background(), pressureCfg.Duration.Duration)
+ defer cancel()
+ ticker := time.NewTicker(pressureCfg.ReqTime.Duration)
+ resCh := make(chan bool, 1000)
+
+ //handle result
+ go p.handleResponse(pressureCtx, resCh, result)
+
+ //statistics the running time
+ start := time.Now()
+FOR:
+ for {
+ select {
+ case <-ctx.Done():
+ break FOR
+ case <-pressureCtx.Done():
+ break FOR
+ case <-ticker.C:
+ for i := 0; i < pressureCfg.ConcurrentNum; i++ {
+ totalReq += pressureCfg.ReqNum
+ //todo: handle err
+
+ //put wg here to prevent: when root ctx is closed,but some exec task do not start yet
+ p.wg.Add(1)
+ go p.exec(pressureCtx, pressureCfg.ReqNum, resCh)
+ }
+ }
+ }
+
+ //occur when pressureCtx or root ctx closed
+
+ //wait all exec calls return,we can safely close the result channel
+ p.wg.Wait()
+ end := time.Now()
+ p.Result.Duration = end.Sub(start)
+ close(resCh)
+
+ //wait collect results channel finished
+ <-p.finishSignalCh
+
+ //when all task finished,update active
+ p.Active = false
+}
+
+func (p *Pressure) exec(ctx context.Context, times int, res chan bool) {
+For:
+ for i := 0; i < times; i++ {
+ select {
+ case <-ctx.Done():
+ break For
+ default:
+ }
+ if len(p.Tasks) == 0 {
+ return
+ }
+ for i := range p.Tasks {
+ //generate diff sql, put result into channel
+ args := randomArgs(p.Tasks[i].Args)
+ _, err := db.Exec(p.Tasks[i].SQL, args)
+ res <- err == nil
+ }
+ }
+ p.wg.Done()
Review Comment:
use ` defer p.wg.Done()` at the beginning of this func.
##########
shardingsphere-operator/pkg/pressure/utils.go:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package pressure
+
+import (
+ "fmt"
+ "math/rand"
+ "strings"
+ "time"
+)
+
+func init() {
+ rand.Seed(time.Now().UnixNano())
+}
+
+const charset = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
Review Comment:
`golang-sdk` has `random string` func.
https://github.com/database-mesh/golang-sdk/tree/main/pkg/random
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "Xu-Wentao (via GitHub)" <gi...@apache.org>.
Xu-Wentao commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545534437
add more meaningful test to cover your core func like `exec pressure`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1543221979
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1543232540
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545305107
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1545506396
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #358: feat(operator): add-pressure-exec replace job(get pod log)
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #358:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/358#issuecomment-1547202223
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=358)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org