You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "js661818 (via GitHub)" <gi...@apache.org> on 2023/03/03 10:47:10 UTC
[GitHub] [airflow] js661818 opened a new issue, #29897: Import error of new dags cannot be show on web ui for common users
js661818 opened a new issue, #29897:
URL: https://github.com/apache/airflow/issues/29897
### Apache Airflow version
2.5.1
### What happened
When we put a new dag in airflow and the dag contains some error which cannot be parsed by the airflow scheduler,
* The common role user is assigned comm role which has the permission of **read Import Error**
* Expectation: we expect thec should be seen in ui by the dag's user(controlled by access_control)
* Result : We cannot see the **import error** by common Role user(only admin can see it )
- admin see this:
- common user see no dag or **import error**
### What you think should happen instead
_No response_
### How to reproduce
Just use a error new dag which grants the permission to common user not a admin
### Operating System
Centos7
### Versions of Apache Airflow Providers
2.5.0
### Deployment
Docker-Compose
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #29897: Import error of new dags cannot be show on web ui for common users
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1680850873
feel free
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ananth-sabhapathi commented on issue #29897: Import error of new dags cannot be show on web ui for common users
Posted by "ananth-sabhapathi (via GitHub)" <gi...@apache.org>.
ananth-sabhapathi commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1677889928
Yes, @potiuk . Still we have this issue..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #29897: Import error of new dags cannot be show on web ui for common users
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1453333100
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Import error of new dags cannot be shown on web UI for common users [airflow]
Posted by "ananth-sabhapathi (via GitHub)" <gi...@apache.org>.
ananth-sabhapathi commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1799210177
So this is an issue with the latest version too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Import error of new dags cannot be shown on web UI for common users [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1970616571
No idea. If someone provide more details, mayb someone will look at it - not sure why tagging me would help here. Ideally - if someone adds more information and logs here, there is a chance somoene will diagnose and fix it. I think everyone's case is different - dpending on the conrete set of permissions and ways how their dags have permissions set the access might be possible or not.
So describing more details about what permissions your users have, what permissions your roles have and what permissions your dags have, might help someone to solve the issues - note that we had recently a few security fixes that LIMITED permissions to dag imports because they were too broad. So I suggest to take a close look at your permissions and see if the user has the right set of permissions (and I cannot have an easy answer what permissions is the right set because if you have your own custom permissions and roles set (as was in the original issue) - it's up to you to build them in the way that makes sense for you.
Also if you turn on debug logs - you might be able to see why the user cannot see the dag. So if you gather all the information, permission configuration and logs - it **might** help someone to investigate it
Also - yes - there were some fixes since 2.6 to that, so its's likely 2.8.2 is more accurate about it - but if you have custom set of permissions, then you need to make sure they are as you expect them to have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #29897: Import error of new dags cannot be show on web ui for common users
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1454850546
Feel free to take a stab on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Import error of new dags cannot be shown on web UI for common users [airflow]
Posted by "ahipp13 (via GitHub)" <gi...@apache.org>.
ahipp13 commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1779790643
This is still open in 2.6.3. Commenting here because I want to know if there are any updates on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] timlichen commented on issue #29897: Import error of new dags cannot be show on web ui for common users
Posted by "timlichen (via GitHub)" <gi...@apache.org>.
timlichen commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1680681639
Hey @potiuk, I'm interested in taking this on if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Import error of new dags cannot be shown on web UI for common users [airflow]
Posted by "timlichen (via GitHub)" <gi...@apache.org>.
timlichen commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1779820918
I was unable to replicate this error/behavior when I looked into this previously, it may no longer be an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Import error of new dags cannot be shown on web UI for common users [airflow]
Posted by "ahipp13 (via GitHub)" <gi...@apache.org>.
ahipp13 commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1779842177
@timlichen I am able to replicate this behavior with my setup. I have 2 roles:
TEAM_ROLE:
Normal User role:
We run on kubernetes with a git sync sidecar. When we upload a DAG to this sidecar for the first time with this in the access control:
access_control={'TEAM_ROLE': ['can_edit', 'can_read']}
The team role cannot see the import error:
But the user role can:
So this is still an issue. I am looking into a workaround where it just emails out if there is an import error as I do not have the time to write my very own custom security manager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #29897: Import error of new dags cannot be show on web ui for common users
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1676475490
> Is this still a open issue in 2.6.3 version?
Can you check it and let us know please @ananth-sabhapathi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ananth-sabhapathi commented on issue #29897: Import error of new dags cannot be show on web ui for common users
Posted by "ananth-sabhapathi (via GitHub)" <gi...@apache.org>.
ananth-sabhapathi commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1674095680
Is this still a open issue in 2.6.3 version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Import error of new dags cannot be shown on web UI for common users [airflow]
Posted by "priya369 (via GitHub)" <gi...@apache.org>.
priya369 commented on issue #29897:
URL: https://github.com/apache/airflow/issues/29897#issuecomment-1970489250
@potiuk still the issue is there in 2.6.3 version,any update on fix of this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org