[GitHub] [beam] kennknowles commented on a change in pull request #14322: [BEAM-449] Support PCollectionList in PAssert

[GitBox <gi...@apache.org>]

kennknowles commented on a change in pull request #14322:
URL: https://github.com/apache/beam/pull/14322#discussion_r602433042



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java
##########
@@ -596,4 +598,138 @@ public void countAssertsMultipleCallsIndependent() {
 
     assertThat(PAssert.countAsserts(pipeline), equalTo(3));
   }
+
+  @Test
+  public void testPAssertThatFlattened() {

Review comment:
       I think this needs `@Category(NeedsRunner.class)` which will cause it to be executed on the direct runner in the `:runners:direct-java:needsRunnerTests` task. See here: https://scans.gradle.com/s/rlhjzeofa5ytc/tests?toggled=WyI6cnVubmVyczpkaXJlY3QtamF2YS1uZWVkc3J1bm5lcnRlc3RzLW9yZy5hcGFjaGUuYmVhbS5zZGsuaW8iLCI6cnVubmVyczpkaXJlY3QtamF2YS1uZWVkc3J1bm5lcnRlc3RzLW9yZy5hcGFjaGUuYmVhbS5zZGsudHJhbnNmb3JtcyIsIjpydW5uZXJzOmRpcmVjdC1qYXZhLW5lZWRzcnVubmVydGVzdHMtb3JnLmFwYWNoZS5iZWFtLnNkay5zY2hlbWFzLnRyYW5zZm9ybXMiXQ#:runners:direct-java-needsrunnertests-org.apache.beam.sdk.testing-passerttest
   
   This test was executed in 66ms according to Jenkins but in fact the `:sdks:java:core:test` task was pulled FROM-CACHE as I guess a prior run on this PR populated the cache: https://scans.gradle.com/s/rlhjzeofa5ytc/timeline#cblz6an6jai7a
   
   I am actually surprised it did not fail since it should have abandoned node enforcement, which is a feature of the `@Rule TestPipeline` to protect users from writing tests but forgetting to run the pipeline.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org