[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10843 )

Change subject: IMPALA-4784: Remove InProcessStatestore
......................................................................


Patch Set 3:

(3 comments)

Seems good, thanks for the cleanup!

http://gerrit.cloudera.org:8080/#/c/10843/3/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/10843/3/be/src/exprs/expr-test.cc@8738
PS3, Line 8738:   Statestore* statestore = new Statestore(metrics.get());
Would it make sense to make this a global scoped_ptr or similar? Seems trivial to avoid the memory leak now.


http://gerrit.cloudera.org:8080/#/c/10843/3/be/src/service/session-expiry-test.cc
File be/src/service/session-expiry-test.cc:

http://gerrit.cloudera.org:8080/#/c/10843/3/be/src/service/session-expiry-test.cc@53
PS3, Line 53:   Statestore* statestore = new Statestore(metrics.get());
Same question


http://gerrit.cloudera.org:8080/#/c/10843/3/be/src/statestore/statestore-test.cc
File be/src/statestore/statestore-test.cc:

http://gerrit.cloudera.org:8080/#/c/10843/3/be/src/statestore/statestore-test.cc@40
PS3, Line 40:   Statestore* statestore = new Statestore(metrics.get());
Same question here and below. Could also use the IGNORE_LEAKING_OBJECT macro.

I figure it's easier to fix this now than have someone else with less context try to fix it later when enabling leak santizier.



-- 
To view, visit http://gerrit.cloudera.org:8080/10843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2621873e593b36c9612a6402ac6c5d8e3b49cde9
Gerrit-Change-Number: 10843
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jul 2018 19:05:57 +0000
Gerrit-HasComments: Yes