You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2019/05/22 00:40:30 UTC
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13398
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
In order to do use the workload runner in tests/performance with
decimal_parquet files, we need to add 'decimal_parquet' to the
list of known file formats.
Ran the core set of tests just to make sure this small change
didn't mess anything up. Everything seemed fine.
Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
---
M tests/common/test_dimensions.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/13398/1
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 3:
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4372/
I think this one hit IMPALA-8610
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 01 Jun 2019 17:44:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4372/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 31 May 2019 20:29:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 3:
I kicked off the jenkins job :) Seemed safe to do
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 31 May 2019 20:30:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 31 May 2019 20:29:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 2:
> Patch Set 2:
>
> Does this end up increasing the exhaustive test runtime substantially by adding yet another dimension? Or is the dimension generation not driven from this constant?
>
> If so, do we think this is necessary/useful coverage?
I'm honestly not sure, so I'm running an exhaustive build now to confirm. But my understanding is that this constant won't affect that. If you git grep for KNOWN_FILE_FORMATS, it shows up in very few places.
The context of this patch is that I tried to run the workload runner against Impala on a deployed cluster, and I'd loaded decimal parquet data ahead of time. However, the convention (admittedly a bit arbitrarily) is that db's are named <db_name>_<file_format>_<compresson type>. The error I'm seeing is...
17:10:01 Traceback (most recent call last):
17:10:01 File "/data/jenkins/workspace/Quasar-Executor/Impala-workload-runner/bin/run-workload.py", line 246, in <module>
17:10:01 workload_runners.append(WorkloadRunner(workload, scale_factor, config))
17:10:01 File "/data/jenkins/workspace/Quasar-Executor/Impala-workload-runner/tests/performance/workload_runner.py", line 73, in __init__
17:10:01 self._generate_test_vectors()
17:10:01 File "/data/jenkins/workspace/Quasar-Executor/Impala-workload-runner/tests/performance/workload_runner.py", line 90, in _generate_test_vectors
17:10:01 self._test_vectors.append(TableFormatInfo.create_from_string(dataset, tf))
17:10:01 File "/data/jenkins/workspace/Quasar-Executor/Impala-workload-runner/tests/common/test_dimensions.py", line 80, in create_from_string
17:10:01 compression_type=compression_type)
17:10:01 File "/data/jenkins/workspace/Quasar-Executor/Impala-workload-runner/tests/common/test_dimensions.py", line 42, in __init__
17:10:01 self.__validate()
17:10:01 File "/data/jenkins/workspace/Quasar-Executor/Impala-workload-runner/tests/common/test_dimensions.py", line 46, in __validate
17:10:01 raise ValueError, 'Unknown file format: %s' % self.file_format
17:10:01 ValueError: Unknown file format: decimal_parquet
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 22 May 2019 20:59:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 2:
Does this end up increasing the exhaustive test runtime substantially by adding yet another dimension? Or is the dimension generation not driven from this constant?
If so, do we think this is necessary/useful coverage?
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 22 May 2019 04:18:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13398
to look at the new patch set (#2).
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
In order use the workload runner in tests/performance with
decimal_parquet tables, we need to add 'decimal_parquet' to the
list of known file formats.
Ran the core set of tests just to make sure this small change
didn't mess anything up. Everything seemed fine.
Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
---
M tests/common/test_dimensions.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/13398/2
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4380/
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 01 Jun 2019 23:34:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4380/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 01 Jun 2019 18:08:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 01 Jun 2019 18:08:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 2: Code-Review+1
This isn't referenced outside of the file - it's purely used for input validation. The actual data sets and workloads are driven by testdata/workloads/ and testdata/datasets
We could consider just removing the validation if we're OK with it failing later on when it can't find the data set definition and/or database and/or tables. But this seems fine to unblock.
Another possible solution would be to skip the validation when TableFormatInfo is created from tests/performance/workload_runner.py
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 22 May 2019 22:38:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3316/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 22 May 2019 01:40:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4372/
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 01 Jun 2019 02:04:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db
Gerrit-Change-Number: 13398
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 23 May 2019 03:13:00 +0000
Gerrit-HasComments: No