You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org> on 2011/04/08 00:05:05 UTC

[jira] [Commented] (WICKET-3603) DataTable row groups are present in markup even when they contain no rows.

    [ https://issues.apache.org/jira/browse/WICKET-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017178#comment-13017178 ] 

Bertrand Guay-Paquet commented on WICKET-3603:
----------------------------------------------

Please see attached DataTableToolbars.patch for a proposed patch to fix the occurance of <thead> and <tfoot>.

There is still a problem when the DataTable has no records however. In that case, we have an empty <tbody> which is not valid html. <tbody> cannot be simply removed because a non-empty table body is required.

I wasn't sure what to do in that case so I left it out of the first patch.

> DataTable row groups are present in markup even when they contain no rows.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-3603
>                 URL: https://issues.apache.org/jira/browse/WICKET-3603
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.5-RC3
>            Reporter: Bertrand Guay-Paquet
>              Labels: datatable
>         Attachments: DataTableToolbars.patch
>
>
> As per the HTML spec :
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row group must contain at least one row, defined by the TR element."
> There is no check in place to remove the row group tags from the output if they don't contain any row.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira