You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/24 00:55:53 UTC
[GitHub] [tvm] jwfromm opened a new pull request #8321: [Relay][Frontend][Onnx] Enable group_conv1d import through conv2d conversion.
jwfromm opened a new pull request #8321:
URL: https://github.com/apache/tvm/pull/8321
TVM doesn't support `group_conv1d` currently and adding it formally is a non-trivial amount of work. Meanwhile, we're encountering an increasing number of models that use it. As an interim solution, we can import `group_conv1d` using `group_conv2d` by simply adding a new spatial axis with size 1. This PR adds that converter into the onnx frontend along with corresponding tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #8321: [Relay][Frontend][Onnx] Enable group_conv1d import through conv2d conversion.
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #8321:
URL: https://github.com/apache/tvm/pull/8321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on a change in pull request #8321: [Relay][Frontend][Onnx] Enable group_conv1d import through conv2d conversion.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on a change in pull request #8321:
URL: https://github.com/apache/tvm/pull/8321#discussion_r657566019
##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -4641,85 +4657,85 @@ def repeat(N, D):
if __name__ == "__main__":
- test_flatten()
- test_reshape()
- test_shape()
- test_expand()
- test_power()
- test_squeeze()
- test_unsqueeze()
- test_slice()
- test_floor()
- test_ceil()
- test_round()
- test_isinf()
- test_isnan()
- test_clip()
- test_clip_min_max_as_inputs()
- test_onehot()
- test_gemm()
- test_matmul()
- test_gather()
- test_gatherelements()
- test_gather_nd()
- test_scatter()
- test_lrn()
- test_instance_norm()
- test_upsample()
- test_forward_min()
- test_forward_max()
- test_forward_mean()
- test_forward_hardsigmoid()
- test_forward_arg_min_max()
- test_softmax()
- test_constantofshape()
- test_all_reduce_funcs()
- test_pad()
- test_split()
- test_binary_ops()
- test_unary_ops()
- test_leaky_relu()
- test_elu()
- test_selu()
- test_prelu()
- test_ThresholdedRelu()
- test_LogSoftmax()
- test_resnet()
- test_inception()
- test_densenet()
- test_sign()
- test_not()
- test_and()
- test_tile()
- test_erf()
- test_where()
- test_or()
- test_depth_to_space()
- test_space_to_depth()
- test_batch_norm()
- test_batch_norm_dynamic_subgraph()
+ # test_flatten()
+ # test_reshape()
+ # test_shape()
+ # test_expand()
+ # test_power()
+ # test_squeeze()
+ # test_unsqueeze()
+ # test_slice()
+ # test_floor()
+ # test_ceil()
+ # test_round()
+ # test_isinf()
+ # test_isnan()
+ # test_clip()
+ # test_clip_min_max_as_inputs()
+ # test_onehot()
+ # test_gemm()
+ # test_matmul()
+ # test_gather()
+ # test_gatherelements()
+ # test_gather_nd()
+ # test_scatter()
+ # test_lrn()
+ # test_instance_norm()
+ # test_upsample()
+ # test_forward_min()
+ # test_forward_max()
+ # test_forward_mean()
+ # test_forward_hardsigmoid()
+ # test_forward_arg_min_max()
+ # test_softmax()
+ # test_constantofshape()
+ # test_all_reduce_funcs()
+ # test_pad()
+ # test_split()
+ # test_binary_ops()
+ # test_unary_ops()
+ # test_leaky_relu()
+ # test_elu()
+ # test_selu()
+ # test_prelu()
+ # test_ThresholdedRelu()
+ # test_LogSoftmax()
+ # test_resnet()
+ # test_inception()
+ # test_densenet()
+ # test_sign()
+ # test_not()
+ # test_and()
+ # test_tile()
+ # test_erf()
+ # test_where()
+ # test_or()
+ # test_depth_to_space()
+ # test_space_to_depth()
+ # test_batch_norm()
+ # test_batch_norm_dynamic_subgraph()
test_conv()
- test_convtranspose()
- test_unsqueeze_constant()
- test_pooling()
- test_lppool()
- test_lstm()
- test_gru()
- test_resize()
- test_nonzero()
- test_topk()
- test_mod()
- test_xor()
- test_max_roi_pool()
- test_roi_align()
- test_range()
- test_loop()
- test_size()
- test_maxunpool()
- test_softplus()
- test_cumsum()
- test_wrong_input()
- test_aten()
- test_reverse_sequence()
- test_eyelike()
- test_qlinearconv()
+ # test_convtranspose()
+ # test_unsqueeze_constant()
+ # test_pooling()
+ # test_lppool()
+ # test_lstm()
+ # test_gru()
+ # test_resize()
+ # test_nonzero()
+ # test_topk()
+ # test_mod()
+ # test_xor()
+ # test_max_roi_pool()
+ # test_roi_align()
+ # test_range()
+ # test_loop()
+ # test_size()
+ # test_maxunpool()
+ # test_softplus()
+ # test_cumsum()
+ # test_wrong_input()
+ # test_aten()
+ # test_reverse_sequence()
+ # test_eyelike()
+ # test_qlinearconv()
Review comment:
Whoops, thanks for catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #8321: [Relay][Frontend][Onnx] Enable group_conv1d import through conv2d conversion.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #8321:
URL: https://github.com/apache/tvm/pull/8321#issuecomment-867252831
@mbrookhart @masahi can you guys take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on a change in pull request #8321: [Relay][Frontend][Onnx] Enable group_conv1d import through conv2d conversion.
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on a change in pull request #8321:
URL: https://github.com/apache/tvm/pull/8321#discussion_r657564204
##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -4641,85 +4657,85 @@ def repeat(N, D):
if __name__ == "__main__":
- test_flatten()
- test_reshape()
- test_shape()
- test_expand()
- test_power()
- test_squeeze()
- test_unsqueeze()
- test_slice()
- test_floor()
- test_ceil()
- test_round()
- test_isinf()
- test_isnan()
- test_clip()
- test_clip_min_max_as_inputs()
- test_onehot()
- test_gemm()
- test_matmul()
- test_gather()
- test_gatherelements()
- test_gather_nd()
- test_scatter()
- test_lrn()
- test_instance_norm()
- test_upsample()
- test_forward_min()
- test_forward_max()
- test_forward_mean()
- test_forward_hardsigmoid()
- test_forward_arg_min_max()
- test_softmax()
- test_constantofshape()
- test_all_reduce_funcs()
- test_pad()
- test_split()
- test_binary_ops()
- test_unary_ops()
- test_leaky_relu()
- test_elu()
- test_selu()
- test_prelu()
- test_ThresholdedRelu()
- test_LogSoftmax()
- test_resnet()
- test_inception()
- test_densenet()
- test_sign()
- test_not()
- test_and()
- test_tile()
- test_erf()
- test_where()
- test_or()
- test_depth_to_space()
- test_space_to_depth()
- test_batch_norm()
- test_batch_norm_dynamic_subgraph()
+ # test_flatten()
+ # test_reshape()
+ # test_shape()
+ # test_expand()
+ # test_power()
+ # test_squeeze()
+ # test_unsqueeze()
+ # test_slice()
+ # test_floor()
+ # test_ceil()
+ # test_round()
+ # test_isinf()
+ # test_isnan()
+ # test_clip()
+ # test_clip_min_max_as_inputs()
+ # test_onehot()
+ # test_gemm()
+ # test_matmul()
+ # test_gather()
+ # test_gatherelements()
+ # test_gather_nd()
+ # test_scatter()
+ # test_lrn()
+ # test_instance_norm()
+ # test_upsample()
+ # test_forward_min()
+ # test_forward_max()
+ # test_forward_mean()
+ # test_forward_hardsigmoid()
+ # test_forward_arg_min_max()
+ # test_softmax()
+ # test_constantofshape()
+ # test_all_reduce_funcs()
+ # test_pad()
+ # test_split()
+ # test_binary_ops()
+ # test_unary_ops()
+ # test_leaky_relu()
+ # test_elu()
+ # test_selu()
+ # test_prelu()
+ # test_ThresholdedRelu()
+ # test_LogSoftmax()
+ # test_resnet()
+ # test_inception()
+ # test_densenet()
+ # test_sign()
+ # test_not()
+ # test_and()
+ # test_tile()
+ # test_erf()
+ # test_where()
+ # test_or()
+ # test_depth_to_space()
+ # test_space_to_depth()
+ # test_batch_norm()
+ # test_batch_norm_dynamic_subgraph()
test_conv()
- test_convtranspose()
- test_unsqueeze_constant()
- test_pooling()
- test_lppool()
- test_lstm()
- test_gru()
- test_resize()
- test_nonzero()
- test_topk()
- test_mod()
- test_xor()
- test_max_roi_pool()
- test_roi_align()
- test_range()
- test_loop()
- test_size()
- test_maxunpool()
- test_softplus()
- test_cumsum()
- test_wrong_input()
- test_aten()
- test_reverse_sequence()
- test_eyelike()
- test_qlinearconv()
+ # test_convtranspose()
+ # test_unsqueeze_constant()
+ # test_pooling()
+ # test_lppool()
+ # test_lstm()
+ # test_gru()
+ # test_resize()
+ # test_nonzero()
+ # test_topk()
+ # test_mod()
+ # test_xor()
+ # test_max_roi_pool()
+ # test_roi_align()
+ # test_range()
+ # test_loop()
+ # test_size()
+ # test_maxunpool()
+ # test_softplus()
+ # test_cumsum()
+ # test_wrong_input()
+ # test_aten()
+ # test_reverse_sequence()
+ # test_eyelike()
+ # test_qlinearconv()
Review comment:
Please remove the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org