You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/06 17:15:59 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10526: feat: SIP-34 card/grid views for dashboards and charts
codecov-commenter edited a comment on pull request #10526:
URL: https://github.com/apache/incubator-superset/pull/10526#issuecomment-670061923
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10526?src=pr&el=h1) Report
> Merging [#10526](https://codecov.io/gh/apache/incubator-superset/pull/10526?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ece91928a9339190163c0bc72b96e51217a90d1e&el=desc) will **decrease** coverage by `4.51%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10526/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10526?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10526 +/- ##
==========================================
- Coverage 63.60% 59.09% -4.52%
==========================================
Files 763 354 -409
Lines 36120 22738 -13382
Branches 3408 0 -3408
==========================================
- Hits 22973 13436 -9537
+ Misses 13034 9302 -3732
+ Partials 113 0 -113
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.09% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10526?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `73.89% <ø> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `93.54% <0.00%> (-0.21%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.30% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | | |
| [...t-frontend/src/dashboard/util/setPeriodicRunner.ts](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NldFBlcmlvZGljUnVubmVyLnRz) | | |
| [...ntend/src/dashboard/util/backgroundStyleOptions.ts](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2JhY2tncm91bmRTdHlsZU9wdGlvbnMudHM=) | | |
| [.../src/explore/components/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9GaWx0ZXJEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
| [...end/src/components/Select/WindowedSelect/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L2luZGV4LnRzeA==) | | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/10526/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10526?src=pr&el=footer). Last update [ece9192...1600583](https://codecov.io/gh/apache/incubator-superset/pull/10526?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org