[GitHub] [superset] kgabryje commented on pull request #20572: feat: Renders Explore in SPA

[GitBox <gi...@apache.org>]

kgabryje commented on PR #20572:
URL: https://github.com/apache/superset/pull/20572#issuecomment-1174324425

   We need to replace links to Explore from Datasets List - we still use `<a>` there. However, I'm fine with doing that in a separate PR, since there's an edge case to consider - dataset can link to an external website instead of explore, and for external websites we can't use React Router links. We probably should first create a generic link component, which would detect if url is internal (if so, use React Router link) or external (use HTML anchor)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org