[GitHub] [flink] aljoscha opened a new pull request #9090: [FLINK-13124] Don't forward exceptions when finishing SourceStreamTask

[GitBox <gi...@apache.org>]

aljoscha opened a new pull request #9090: [FLINK-13124] Don't forward exceptions when finishing SourceStreamTask
URL: https://github.com/apache/flink/pull/9090
 
 
   ## What is the purpose of the change
   
   Before, exceptions that occurred after cancelling a source (as the
   KafkaConsumer did, for example) would make a job fail when attempting a
   "stop-with-savepoint". Now we ignore those exceptions.
   
   ## Brief change log
   
   - add a `isFinished` flag in `SourceStreamTask`
   - check this flag before re-throwing exceptions
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Added unit tests in `SourceStreamTaskTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Checkpointing, yes, because it fixes stop-with-savepoint
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services