You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by siddharth anand <sa...@apache.org> on 2016/08/12 02:28:49 UTC
Shout out!
FYI!
Just wanted to give a special shout-out for jlowin for writing a great
merge tool for committers. Thx to this tool, merging your PR is super easy.
-s
Re: Shout out!
Posted by siddharth anand <sa...@apache.org>.
And merged! Thx Jeremiah!
-s
On Fri, Aug 12, 2016 at 2:56 PM, Jeremiah Lowin <jl...@apache.org> wrote:
> Thanks for the kind words! While I appreciate it, just to be clear, this
> script began life as the PR tool for Spark (and I've credited it
> appropriately)... though at this point it's so heavily modified that it
> definitely stands alone and, if I may say, is pretty damn cool!
>
> Added some very cool new functionality just a few minutes ago in fact:
> - automatically wrap commit messages as 50 characters (preserves newlines
> and indentation)
> - if a user mentions a JIRA issue anywhere in their PR or commits, it is
> automatically prepended to the squash commit subject.
>
> Basically: no more asking authors to edit their commits or PRs.
> Nonetheless, authors: this doesn't let you off the hook... it's just a
> safety net. :)
>
> Call it the "making Sid and Bolke happy" PR. The goodness is here:
> https://github.com/apache/incubator-airflow/pull/1728
>
>
> On Fri, Aug 12, 2016 at 3:42 PM Chris Riccomini <cr...@apache.org>
> wrote:
>
> > Perhaps here? https://yetus.apache.org/
> >
> > On Fri, Aug 12, 2016 at 12:08 PM, siddharth anand <sa...@apache.org>
> > wrote:
> > > Mentors,
> > > how do we contribute this goodness to other apache projects?
> > >
> > > -s
> > >
> > > On Fri, Aug 12, 2016 at 12:04 PM, Maxime Beauchemin <
> > > maximebeauchemin@gmail.com> wrote:
> > >
> > >> OMG yes!
> > >>
> > >> We should broadcast it to all other Apache projects that uses git.
> > >>
> > >> Max
> > >>
> > >> On Fri, Aug 12, 2016 at 9:46 AM, Dan Davydov <dan.davydov@airbnb.com.
> > >> invalid
> > >> > wrote:
> > >>
> > >> > +1
> > >> >
> > >> > On Aug 12, 2016 8:02 AM, "Chris Riccomini" <cr...@apache.org>
> > >> wrote:
> > >> >
> > >> > > Same. It's awesome.
> > >> > >
> > >> > > On Thu, Aug 11, 2016 at 7:28 PM, siddharth anand <
> sanand@apache.org
> > >
> > >> > > wrote:
> > >> > > > FYI!
> > >> > > > Just wanted to give a special shout-out for jlowin for writing a
> > >> great
> > >> > > > merge tool for committers. Thx to this tool, merging your PR is
> > super
> > >> > > easy.
> > >> > > >
> > >> > > > -s
> > >> > >
> > >> >
> > >>
> >
>
Re: Shout out!
Posted by Jeremiah Lowin <jl...@apache.org>.
Thanks for the kind words! While I appreciate it, just to be clear, this
script began life as the PR tool for Spark (and I've credited it
appropriately)... though at this point it's so heavily modified that it
definitely stands alone and, if I may say, is pretty damn cool!
Added some very cool new functionality just a few minutes ago in fact:
- automatically wrap commit messages as 50 characters (preserves newlines
and indentation)
- if a user mentions a JIRA issue anywhere in their PR or commits, it is
automatically prepended to the squash commit subject.
Basically: no more asking authors to edit their commits or PRs.
Nonetheless, authors: this doesn't let you off the hook... it's just a
safety net. :)
Call it the "making Sid and Bolke happy" PR. The goodness is here:
https://github.com/apache/incubator-airflow/pull/1728
On Fri, Aug 12, 2016 at 3:42 PM Chris Riccomini <cr...@apache.org>
wrote:
> Perhaps here? https://yetus.apache.org/
>
> On Fri, Aug 12, 2016 at 12:08 PM, siddharth anand <sa...@apache.org>
> wrote:
> > Mentors,
> > how do we contribute this goodness to other apache projects?
> >
> > -s
> >
> > On Fri, Aug 12, 2016 at 12:04 PM, Maxime Beauchemin <
> > maximebeauchemin@gmail.com> wrote:
> >
> >> OMG yes!
> >>
> >> We should broadcast it to all other Apache projects that uses git.
> >>
> >> Max
> >>
> >> On Fri, Aug 12, 2016 at 9:46 AM, Dan Davydov <dan.davydov@airbnb.com.
> >> invalid
> >> > wrote:
> >>
> >> > +1
> >> >
> >> > On Aug 12, 2016 8:02 AM, "Chris Riccomini" <cr...@apache.org>
> >> wrote:
> >> >
> >> > > Same. It's awesome.
> >> > >
> >> > > On Thu, Aug 11, 2016 at 7:28 PM, siddharth anand <sanand@apache.org
> >
> >> > > wrote:
> >> > > > FYI!
> >> > > > Just wanted to give a special shout-out for jlowin for writing a
> >> great
> >> > > > merge tool for committers. Thx to this tool, merging your PR is
> super
> >> > > easy.
> >> > > >
> >> > > > -s
> >> > >
> >> >
> >>
>
Re: Shout out!
Posted by Chris Riccomini <cr...@apache.org>.
Perhaps here? https://yetus.apache.org/
On Fri, Aug 12, 2016 at 12:08 PM, siddharth anand <sa...@apache.org> wrote:
> Mentors,
> how do we contribute this goodness to other apache projects?
>
> -s
>
> On Fri, Aug 12, 2016 at 12:04 PM, Maxime Beauchemin <
> maximebeauchemin@gmail.com> wrote:
>
>> OMG yes!
>>
>> We should broadcast it to all other Apache projects that uses git.
>>
>> Max
>>
>> On Fri, Aug 12, 2016 at 9:46 AM, Dan Davydov <dan.davydov@airbnb.com.
>> invalid
>> > wrote:
>>
>> > +1
>> >
>> > On Aug 12, 2016 8:02 AM, "Chris Riccomini" <cr...@apache.org>
>> wrote:
>> >
>> > > Same. It's awesome.
>> > >
>> > > On Thu, Aug 11, 2016 at 7:28 PM, siddharth anand <sa...@apache.org>
>> > > wrote:
>> > > > FYI!
>> > > > Just wanted to give a special shout-out for jlowin for writing a
>> great
>> > > > merge tool for committers. Thx to this tool, merging your PR is super
>> > > easy.
>> > > >
>> > > > -s
>> > >
>> >
>>
Re: Shout out!
Posted by siddharth anand <sa...@apache.org>.
Mentors,
how do we contribute this goodness to other apache projects?
-s
On Fri, Aug 12, 2016 at 12:04 PM, Maxime Beauchemin <
maximebeauchemin@gmail.com> wrote:
> OMG yes!
>
> We should broadcast it to all other Apache projects that uses git.
>
> Max
>
> On Fri, Aug 12, 2016 at 9:46 AM, Dan Davydov <dan.davydov@airbnb.com.
> invalid
> > wrote:
>
> > +1
> >
> > On Aug 12, 2016 8:02 AM, "Chris Riccomini" <cr...@apache.org>
> wrote:
> >
> > > Same. It's awesome.
> > >
> > > On Thu, Aug 11, 2016 at 7:28 PM, siddharth anand <sa...@apache.org>
> > > wrote:
> > > > FYI!
> > > > Just wanted to give a special shout-out for jlowin for writing a
> great
> > > > merge tool for committers. Thx to this tool, merging your PR is super
> > > easy.
> > > >
> > > > -s
> > >
> >
>
Re: Shout out!
Posted by Maxime Beauchemin <ma...@gmail.com>.
OMG yes!
We should broadcast it to all other Apache projects that uses git.
Max
On Fri, Aug 12, 2016 at 9:46 AM, Dan Davydov <dan.davydov@airbnb.com.invalid
> wrote:
> +1
>
> On Aug 12, 2016 8:02 AM, "Chris Riccomini" <cr...@apache.org> wrote:
>
> > Same. It's awesome.
> >
> > On Thu, Aug 11, 2016 at 7:28 PM, siddharth anand <sa...@apache.org>
> > wrote:
> > > FYI!
> > > Just wanted to give a special shout-out for jlowin for writing a great
> > > merge tool for committers. Thx to this tool, merging your PR is super
> > easy.
> > >
> > > -s
> >
>
Re: Shout out!
Posted by Dan Davydov <da...@airbnb.com.INVALID>.
+1
On Aug 12, 2016 8:02 AM, "Chris Riccomini" <cr...@apache.org> wrote:
> Same. It's awesome.
>
> On Thu, Aug 11, 2016 at 7:28 PM, siddharth anand <sa...@apache.org>
> wrote:
> > FYI!
> > Just wanted to give a special shout-out for jlowin for writing a great
> > merge tool for committers. Thx to this tool, merging your PR is super
> easy.
> >
> > -s
>
Re: Shout out!
Posted by Chris Riccomini <cr...@apache.org>.
Same. It's awesome.
On Thu, Aug 11, 2016 at 7:28 PM, siddharth anand <sa...@apache.org> wrote:
> FYI!
> Just wanted to give a special shout-out for jlowin for writing a great
> merge tool for committers. Thx to this tool, merging your PR is super easy.
>
> -s