[GitHub] [spark] srowen commented on a change in pull request #27959: [SPARK-31190][SQL] ScalaReflection should erasure non user defined AnyVal type

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #27959: [SPARK-31190][SQL] ScalaReflection should erasure non user defined AnyVal type
URL: https://github.com/apache/spark/pull/27959#discussion_r395137361
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
 ##########
 @@ -611,10 +611,33 @@ object ScalaReflection extends ScalaReflection {
     }
   }
 
+  private def erasure(tpe: Type): Type = {
+    if (isSubtype(tpe, localTypeOf[AnyVal]) && !tpe.toString.startsWith("scala")) {
+      tpe
+    } else {
+      tpe.erasure
 
 Review comment:
   What does erasure do here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org