[GitHub] [doris] ZhangYu0123 commented on a diff in pull request #21102: [fix](pipeline) fix MultiCoreTaskQueue steal take core_id assgin error

["ZhangYu0123 (via GitHub)" <gi...@apache.org>]

ZhangYu0123 commented on code in PR #21102:
URL: https://github.com/apache/doris/pull/21102#discussion_r1241220458


##########
be/src/pipeline/task_queue.cpp:
##########
@@ -182,7 +182,7 @@ PipelineTask* MultiCoreTaskQueue::_steal_take(size_t core_id) {
         DCHECK(next_id < _core_size);
         auto task = _prio_task_queue_list[next_id].try_take(true);
         if (task) {
-            task->set_core_id(next_id);

Review Comment:
   > need change the origin core id seems right？
   
   I think core_id of pipeline task means which core thread the task belong to and which multi core task queue the task belong to.  On the other hand,  previous_core_id of pipeline task means the origin core id.
   So the task is stealed from next_id to the core_id, it should be the core_id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org