[GitHub] [iceberg] rdblue commented on a diff in pull request #5893: Core: Use avro compression properties from table properties while writing Manifest and Manifest list files.

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5893:
URL: https://github.com/apache/iceberg/pull/5893#discussion_r989550107


##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -141,7 +141,24 @@ public static ManifestReader<DataFile> read(
    * @return a manifest writer
    */
   public static ManifestWriter<DataFile> write(PartitionSpec spec, OutputFile outputFile) {
-    return write(1, spec, outputFile, null);
+    return write(spec, outputFile, /* compressionCodec */ null, /* compressionLevel */ null);
+  }
+
+  /**
+   * Create a new {@link ManifestWriter}.
+   *
+   * <p>Manifests created by this writer have all entry snapshot IDs set to null. All entries will
+   * inherit the snapshot ID that will be assigned to the manifest on commit.
+   *
+   * @param spec {@link PartitionSpec} used to produce {@link DataFile} partition tuples
+   * @param outputFile the destination file location
+   * @param compressionCodec compression codec for the manifest file
+   * @param compressionLevel compression level of the compressionCodec
+   * @return a manifest writer
+   */
+  public static ManifestWriter<DataFile> write(

Review Comment:
   @sumeetgajjar, this must explicitly set the format version. This is a new method, so the format version should always be included. Older methods did not use a format version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org