You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by patricker <gi...@git.apache.org> on 2018/06/29 16:52:51 UTC

[GitHub] nifi pull request #2826: NIFI-4535 Set the Page Title to the name of the Roo...

GitHub user patricker opened a pull request:

    https://github.com/apache/nifi/pull/2826

    NIFI-4535 Set the Page Title to the name of the Root Process Group

    NiFi will automatically update the HTML page title to reflect the name of the root processor group.
    
    This code runs whenever a Processor Group is being loaded/reloaded, allowing for immediate updates to the title.
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/patricker/nifi NIFI-4535

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2826.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2826
    
----
commit 6a1498e4ec58571fcc75a34db6879d1b71265f76
Author: patricker <pa...@...>
Date:   2018-06-29T16:49:44Z

    NIFI-4535

----


---

[GitHub] nifi pull request #2826: NIFI-4535 Set the Page Title to the name of the Roo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2826


---

[GitHub] nifi issue #2826: NIFI-4535 Set the Page Title to the name of the Root Proce...

Posted by danieljimenez <gi...@git.apache.org>.
Github user danieljimenez commented on the issue:

    https://github.com/apache/nifi/pull/2826
  
    Three cheers.\


---