You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/02 15:48:32 UTC
[GitHub] [shardingsphere] yx9o opened a new pull request, #22607: Remove SQLStatement log in SQLLogger.
yx9o opened a new pull request, #22607:
URL: https://github.com/apache/shardingsphere/pull/22607
Fixes #22453 .
Changes proposed in this pull request:
- Remove log from SQLLogger;
- Remove all @tostring annotation on SQLStatement and SQLSegment class;
- Remove last item of parser code conduct.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22607: Remove SQLStatement log in SQLLogger.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22607:
URL: https://github.com/apache/shardingsphere/pull/22607#issuecomment-1335520473
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22607?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22607](https://codecov.io/gh/apache/shardingsphere/pull/22607?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (921b360) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8da98f0d9c6fa1019d936319c19f69450af7d1de?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8da98f0) will **increase** coverage by `0.00%`.
> The diff coverage is `12.50%`.
```diff
@@ Coverage Diff @@
## master #22607 +/- ##
=========================================
Coverage 50.59% 50.59%
Complexity 2460 2460
=========================================
Files 4115 4115
Lines 57622 57615 -7
Branches 9842 9835 -7
=========================================
Hits 29152 29152
+ Misses 25959 25953 -6
+ Partials 2511 2510 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22607?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...es/expression/DerivedLiteralExpressionSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9pbnNlcnQvdmFsdWVzL2V4cHJlc3Npb24vRGVyaXZlZExpdGVyYWxFeHByZXNzaW9uU2VnbWVudC5qYXZh) | `100.00% <ø> (ø)` | |
| [...ssion/DerivedParameterMarkerExpressionSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9pbnNlcnQvdmFsdWVzL2V4cHJlc3Npb24vRGVyaXZlZFBhcmFtZXRlck1hcmtlckV4cHJlc3Npb25TZWdtZW50LmphdmE=) | `100.00% <ø> (ø)` | |
| [...ardingsphere/infra/executor/sql/log/SQLLogger.java](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9sb2cvU1FMTG9nZ2VyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...end/communication/DatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `24.00% <0.00%> (ø)` | |
| [...oxy/backend/exception/RuleNotExistedException.java](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGNlcHRpb24vUnVsZU5vdEV4aXN0ZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...kend/exception/StorageUnitNotExistedException.java](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGNlcHRpb24vU3RvcmFnZVVuaXROb3RFeGlzdGVkRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...in/mysql/executor/UnicastResourceShowExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2FkbWluL215c3FsL2V4ZWN1dG9yL1VuaWNhc3RSZXNvdXJjZVNob3dFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../hint/executor/ShowShardingHintStatusExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZXhlY3V0b3IvU2hvd1NoYXJkaW5nSGludFN0YXR1c0V4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ackend/handler/distsql/rul/sql/PreviewHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcnVsL3NxbC9QcmV2aWV3SGFuZGxlci5qYXZh) | `3.44% <0.00%> (+0.05%)` | :arrow_up: |
| [...dl/column/position/ColumnAfterPositionSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RkbC9jb2x1bW4vcG9zaXRpb24vQ29sdW1uQWZ0ZXJQb3NpdGlvblNlZ21lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [764 more](https://codecov.io/gh/apache/shardingsphere/pull/22607/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #22607: Remove SQLStatement log in SQLLogger.
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #22607:
URL: https://github.com/apache/shardingsphere/pull/22607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org