You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/16 19:22:52 UTC

[GitHub] [activemq] ehossack-aws commented on a change in pull request #622: Add full.test profile to execute all modules and remove unit tests and itests by default

ehossack-aws commented on a change in pull request #622:
URL: https://github.com/apache/activemq/pull/622#discussion_r595475927



##########
File path: pom.xml
##########
@@ -1489,6 +1486,15 @@
 
   <profiles>
 
+    <profile>
+      <id>full.test</id>
+      <modules>
+        <module>activemq-unit-tests</module>

Review comment:
       Hi wondering if you would entertain my question here :)
   
   Because I don't have a huge amount of context, this question might be naive, but shouldn't the unit tests be the _core_ thing run on a PR? 
   
   In an ideal world I'd expect all unit tests to run, and a subset of integration tests relevant to the components changed. Obviously the latter part is hard, but is this not removing some of the confidence inspiring tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org