You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/11/06 22:48:03 UTC
Review Request 40000: TemporaryDirectoryTest Merge: Point tests to
the Stout version of the `TemporaryDirectoryTest`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40000/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Jie Yu, and Joris Van Remoortere.
Repository: mesos
Description
-------
We have two `TemporaryDirectoryTest` classes, which have almost identical contents.
Note: The `LinuxFilesystemIsolatorTest` will be changed separately, as it requires some special cleanup.
Diffs
-----
src/tests/containerizer/fs_tests.cpp 7fb413359c855eb9d0fc3031e17170eb6744d571
src/tests/containerizer/launch_tests.cpp de655ec884650f6cd208e5a30afb335f4e0dc405
src/tests/containerizer/provisioner_appc_tests.cpp 213e9c02244a8034e46f2b794dc3caf427a1f705
src/tests/containerizer/provisioner_backend_tests.cpp 3347d58d44bd40d704c46a86b9127d40db98b475
src/tests/files_tests.cpp 4b13f5b03a154ff6c011ea63ea106e086f873e2a
src/tests/log_tests.cpp bbf7a7eacc84af753733f87ba953386bc47c8d05
src/tests/protobuf_io_tests.cpp f5e041cbc6e2fe8c7bf8339032d788e2006bb3a3
src/tests/registrar_tests.cpp 2610a567b83ba6d8cdd6f129b9df8fc3ca9620db
src/tests/state_tests.cpp b8cddc5fa530aa465d5575e0136e9c89c2b04b58
Diff: https://reviews.apache.org/r/40000/diff/
Testing
-------
`make check` on OSX.
`sudo make check` on Centos7.
Thanks,
Joseph Wu
Re: Review Request 40000: TemporaryDirectoryTest Merge: Point tests
to the Stout version of the `TemporaryDirectoryTest`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40000/#review105542
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 6, 2015, 10:10 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40000/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 10:10 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3847
> https://issues.apache.org/jira/browse/MESOS-3847
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We have two `TemporaryDirectoryTest` classes, which have almost identical contents.
>
> Note: The `LinuxFilesystemIsolatorTest` will be changed separately, as it requires some special cleanup.
>
>
> Diffs
> -----
>
> src/tests/containerizer/fs_tests.cpp 7fb413359c855eb9d0fc3031e17170eb6744d571
> src/tests/containerizer/launch_tests.cpp de655ec884650f6cd208e5a30afb335f4e0dc405
> src/tests/containerizer/provisioner_appc_tests.cpp 213e9c02244a8034e46f2b794dc3caf427a1f705
> src/tests/containerizer/provisioner_backend_tests.cpp 3347d58d44bd40d704c46a86b9127d40db98b475
> src/tests/files_tests.cpp 4b13f5b03a154ff6c011ea63ea106e086f873e2a
> src/tests/log_tests.cpp bbf7a7eacc84af753733f87ba953386bc47c8d05
> src/tests/protobuf_io_tests.cpp f5e041cbc6e2fe8c7bf8339032d788e2006bb3a3
> src/tests/registrar_tests.cpp 2610a567b83ba6d8cdd6f129b9df8fc3ca9620db
> src/tests/state_tests.cpp b8cddc5fa530aa465d5575e0136e9c89c2b04b58
>
> Diff: https://reviews.apache.org/r/40000/diff/
>
>
> Testing
> -------
>
> `make check` on OSX.
>
> `sudo make check` on Centos7.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 40000: TemporaryDirectoryTest Merge: Point tests
to the Stout version of the `TemporaryDirectoryTest`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40000/
-----------------------------------------------------------
(Updated Nov. 6, 2015, 2:10 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Joris Van Remoortere.
Bugs: MESOS-3847
https://issues.apache.org/jira/browse/MESOS-3847
Repository: mesos
Description
-------
We have two `TemporaryDirectoryTest` classes, which have almost identical contents.
Note: The `LinuxFilesystemIsolatorTest` will be changed separately, as it requires some special cleanup.
Diffs
-----
src/tests/containerizer/fs_tests.cpp 7fb413359c855eb9d0fc3031e17170eb6744d571
src/tests/containerizer/launch_tests.cpp de655ec884650f6cd208e5a30afb335f4e0dc405
src/tests/containerizer/provisioner_appc_tests.cpp 213e9c02244a8034e46f2b794dc3caf427a1f705
src/tests/containerizer/provisioner_backend_tests.cpp 3347d58d44bd40d704c46a86b9127d40db98b475
src/tests/files_tests.cpp 4b13f5b03a154ff6c011ea63ea106e086f873e2a
src/tests/log_tests.cpp bbf7a7eacc84af753733f87ba953386bc47c8d05
src/tests/protobuf_io_tests.cpp f5e041cbc6e2fe8c7bf8339032d788e2006bb3a3
src/tests/registrar_tests.cpp 2610a567b83ba6d8cdd6f129b9df8fc3ca9620db
src/tests/state_tests.cpp b8cddc5fa530aa465d5575e0136e9c89c2b04b58
Diff: https://reviews.apache.org/r/40000/diff/
Testing
-------
`make check` on OSX.
`sudo make check` on Centos7.
Thanks,
Joseph Wu