You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2019/03/30 22:51:46 UTC

[incubator-skywalking] branch jaeger-receiver created (now 165ce04)

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch jaeger-receiver
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git.


      at 165ce04  Move all receiver proto files together, in case the class conflict in gogoproto.

This branch includes the following new commits:

     new 165ce04  Move all receiver proto files together, in case the class conflict in gogoproto.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[incubator-skywalking] 01/01: Move all receiver proto files together, in case the class conflict in gogoproto.

Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch jaeger-receiver
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git

commit 165ce04904f02a8caff7b89347d523c21482e8a7
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Sat Mar 30 15:51:33 2019 -0700

    Move all receiver proto files together, in case the class conflict in gogoproto.
---
 docs/en/guides/How-to-build.md                     |   3 +-
 .../envoy-metrics-receiver-plugin/pom.xml          |  35 +-----
 .../jaeger-receiver-plugin/pom.xml                 |  33 +++++
 oap-server/server-receiver-plugin/pom.xml          |   2 +
 .../pom.xml                                        |   8 +-
 .../src/main/proto/envoy/api/v2/core/base.proto    |   0
 .../envoy/service/metrics/v2/metrics_service.proto |   0
 .../src/main/proto/envoy/type/percent.proto        |   0
 .../src/main/proto/gogoproto/gogo.proto            |   0
 .../src/main/proto/istio-metric.proto              |   0
 .../mixer/adapter/model/v1beta1/extensions.proto   |   0
 .../proto/mixer/adapter/model/v1beta1/report.proto |   0
 .../src/main/proto/policy/v1beta1/type.proto       |   0
 .../src/main/proto/policy/v1beta1/value_type.proto |   0
 .../proto/prometheus/client_model/metrics.proto    |   0
 .../src/main/proto/validate/validate.proto         |   0
 .../pom.xml                                        |   5 +
 .../src/main/proto/gogoproto/gogo.proto            | 136 ---------------------
 18 files changed, 52 insertions(+), 170 deletions(-)

diff --git a/docs/en/guides/How-to-build.md b/docs/en/guides/How-to-build.md
index bc942b9..2a1b483 100644
--- a/docs/en/guides/How-to-build.md
+++ b/docs/en/guides/How-to-build.md
@@ -41,8 +41,7 @@ If you just want to recompile part of the project, you have following options
 1. Set **Generated Source Codes** folders.
     * `grpc-java` and `java` folders in **apm-protocol/apm-network/target/generated-sources/protobuf**
     * `grpc-java` and `java` folders in **oap-server/server-core/target/generated-sources/protobuf**
-    * `grpc-java` and `java` folders in **oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/target/generated-sources/protobuf**
-    * `grpc-java` and `java` folders in **oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/target/generated-sources/protobuf**
+    * `grpc-java` and `java` folders in **oap-server/server-receiver-plugin/receiver-proto/target/generated-sources/protobuf**
     * `grpc-java` and `java` folders in **oap-server/exporter/target/generated-sources/protobuf**
     * `antlr4` folder in **oap-server/generate-tool-grammar/target/generated-sources**
     * `oal` folder in **oap-server/generated-analysis/target/generated-sources**
diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/pom.xml b/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/pom.xml
index 91653a8..aa8d8c6 100644
--- a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/pom.xml
+++ b/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/pom.xml
@@ -31,38 +31,15 @@
     <dependencies>
         <dependency>
             <groupId>org.apache.skywalking</groupId>
+            <artifactId>receiver-proto</artifactId>
+            <version>${project.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.skywalking</groupId>
             <artifactId>skywalking-mesh-receiver-plugin</artifactId>
             <version>${project.version}</version>
         </dependency>
     </dependencies>
 
-    <build>
-        <plugins>
-            <plugin>
-                <groupId>org.xolstice.maven.plugins</groupId>
-                <artifactId>protobuf-maven-plugin</artifactId>
-                <version>0.5.0</version>
-                <configuration>
-                    <!--
-                      The version of protoc must match protobuf-java. If you don't depend on
-                      protobuf-java directly, you will be transitively depending on the
-                      protobuf-java version that grpc depends on.
-                    -->
-                    <protocArtifact>com.google.protobuf:protoc:3.3.0:exe:${os.detected.classifier}
-                    </protocArtifact>
-                    <pluginId>grpc-java</pluginId>
-                    <pluginArtifact>io.grpc:protoc-gen-grpc-java:1.8.0:exe:${os.detected.classifier}
-                    </pluginArtifact>
-                </configuration>
-                <executions>
-                    <execution>
-                        <goals>
-                            <goal>compile</goal>
-                            <goal>compile-custom</goal>
-                        </goals>
-                    </execution>
-                </executions>
-            </plugin>
-        </plugins>
-    </build>
+
 </project>
\ No newline at end of file
diff --git a/oap-server/server-receiver-plugin/jaeger-receiver-plugin/pom.xml b/oap-server/server-receiver-plugin/jaeger-receiver-plugin/pom.xml
new file mode 100644
index 0000000..b40b35a
--- /dev/null
+++ b/oap-server/server-receiver-plugin/jaeger-receiver-plugin/pom.xml
@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  ~
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <artifactId>server-receiver-plugin</artifactId>
+        <groupId>org.apache.skywalking</groupId>
+        <version>6.1.0-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>jaeger-receiver-plugin</artifactId>
+
+
+</project>
\ No newline at end of file
diff --git a/oap-server/server-receiver-plugin/pom.xml b/oap-server/server-receiver-plugin/pom.xml
index 8c32601..0bd27d7 100644
--- a/oap-server/server-receiver-plugin/pom.xml
+++ b/oap-server/server-receiver-plugin/pom.xml
@@ -37,6 +37,8 @@
         <module>envoy-metrics-receiver-plugin</module>
         <module>skywalking-sharing-server-plugin</module>
         <module>skywalking-clr-receiver-plugin</module>
+        <module>jaeger-receiver-plugin</module>
+        <module>receiver-proto</module>
     </modules>
 
     <dependencies>
diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/pom.xml b/oap-server/server-receiver-plugin/receiver-proto/pom.xml
similarity index 88%
copy from oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/pom.xml
copy to oap-server/server-receiver-plugin/receiver-proto/pom.xml
index 91653a8..4d6a634 100644
--- a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/pom.xml
+++ b/oap-server/server-receiver-plugin/receiver-proto/pom.xml
@@ -17,7 +17,9 @@
   ~
   -->
 
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <parent>
         <artifactId>server-receiver-plugin</artifactId>
         <groupId>org.apache.skywalking</groupId>
@@ -25,13 +27,13 @@
     </parent>
     <modelVersion>4.0.0</modelVersion>
 
-    <artifactId>envoy-metrics-receiver-plugin</artifactId>
+    <artifactId>receiver-proto</artifactId>
     <packaging>jar</packaging>
 
     <dependencies>
         <dependency>
             <groupId>org.apache.skywalking</groupId>
-            <artifactId>skywalking-mesh-receiver-plugin</artifactId>
+            <artifactId>skywalking-sharing-server-plugin</artifactId>
             <version>${project.version}</version>
         </dependency>
     </dependencies>
diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/envoy/api/v2/core/base.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/envoy/api/v2/core/base.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/envoy/api/v2/core/base.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/envoy/api/v2/core/base.proto
diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/envoy/service/metrics/v2/metrics_service.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/envoy/service/metrics/v2/metrics_service.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/envoy/service/metrics/v2/metrics_service.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/envoy/service/metrics/v2/metrics_service.proto
diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/envoy/type/percent.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/envoy/type/percent.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/envoy/type/percent.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/envoy/type/percent.proto
diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/gogoproto/gogo.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/gogoproto/gogo.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/gogoproto/gogo.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/gogoproto/gogo.proto
diff --git a/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/istio-metric.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/istio-metric.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/istio-metric.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/istio-metric.proto
diff --git a/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/mixer/adapter/model/v1beta1/extensions.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/mixer/adapter/model/v1beta1/extensions.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/mixer/adapter/model/v1beta1/extensions.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/mixer/adapter/model/v1beta1/extensions.proto
diff --git a/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/mixer/adapter/model/v1beta1/report.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/mixer/adapter/model/v1beta1/report.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/mixer/adapter/model/v1beta1/report.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/mixer/adapter/model/v1beta1/report.proto
diff --git a/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/policy/v1beta1/type.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/policy/v1beta1/type.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/policy/v1beta1/type.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/policy/v1beta1/type.proto
diff --git a/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/policy/v1beta1/value_type.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/policy/v1beta1/value_type.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/policy/v1beta1/value_type.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/policy/v1beta1/value_type.proto
diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/prometheus/client_model/metrics.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/prometheus/client_model/metrics.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/prometheus/client_model/metrics.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/prometheus/client_model/metrics.proto
diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/validate/validate.proto b/oap-server/server-receiver-plugin/receiver-proto/src/main/proto/validate/validate.proto
similarity index 100%
rename from oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/proto/validate/validate.proto
rename to oap-server/server-receiver-plugin/receiver-proto/src/main/proto/validate/validate.proto
diff --git a/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/pom.xml b/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/pom.xml
index 284a992..c4edf3f 100644
--- a/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/pom.xml
+++ b/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/pom.xml
@@ -34,6 +34,11 @@
             <artifactId>skywalking-mesh-receiver-plugin</artifactId>
             <version>${project.version}</version>
         </dependency>
+        <dependency>
+            <groupId>org.apache.skywalking</groupId>
+            <artifactId>receiver-proto</artifactId>
+            <version>${project.version}</version>
+        </dependency>
     </dependencies>
 
     <build>
diff --git a/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/gogoproto/gogo.proto b/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/gogoproto/gogo.proto
deleted file mode 100644
index ff85176..0000000
--- a/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/gogoproto/gogo.proto
+++ /dev/null
@@ -1,136 +0,0 @@
-// Protocol Buffers for Go with Gadgets
-//
-// Copyright (c) 2013, The GoGo Authors. All rights reserved.
-// http://github.com/gogo/protobuf
-//
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions are
-// met:
-//
-//     * Redistributions of source code must retain the above copyright
-// notice, this list of conditions and the following disclaimer.
-//     * Redistributions in binary form must reproduce the above
-// copyright notice, this list of conditions and the following disclaimer
-// in the documentation and/or other materials provided with the
-// distribution.
-//
-// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-syntax = "proto2";
-package gogoproto;
-
-import "google/protobuf/descriptor.proto";
-
-option java_package = "com.google.protobuf";
-option java_outer_classname = "GoGoProtos";
-option go_package = "github.com/gogo/protobuf/gogoproto";
-
-extend google.protobuf.EnumOptions {
-    optional bool goproto_enum_prefix = 62001;
-    optional bool goproto_enum_stringer = 62021;
-    optional bool enum_stringer = 62022;
-    optional string enum_customname = 62023;
-    optional bool enumdecl = 62024;
-}
-
-extend google.protobuf.EnumValueOptions {
-    optional string enumvalue_customname = 66001;
-}
-
-extend google.protobuf.FileOptions {
-    optional bool goproto_getters_all = 63001;
-    optional bool goproto_enum_prefix_all = 63002;
-    optional bool goproto_stringer_all = 63003;
-    optional bool verbose_equal_all = 63004;
-    optional bool face_all = 63005;
-    optional bool gostring_all = 63006;
-    optional bool populate_all = 63007;
-    optional bool stringer_all = 63008;
-    optional bool onlyone_all = 63009;
-
-    optional bool equal_all = 63013;
-    optional bool description_all = 63014;
-    optional bool testgen_all = 63015;
-    optional bool benchgen_all = 63016;
-    optional bool marshaler_all = 63017;
-    optional bool unmarshaler_all = 63018;
-    optional bool stable_marshaler_all = 63019;
-
-    optional bool sizer_all = 63020;
-
-    optional bool goproto_enum_stringer_all = 63021;
-    optional bool enum_stringer_all = 63022;
-
-    optional bool unsafe_marshaler_all = 63023;
-    optional bool unsafe_unmarshaler_all = 63024;
-
-    optional bool goproto_extensions_map_all = 63025;
-    optional bool goproto_unrecognized_all = 63026;
-    optional bool gogoproto_import = 63027;
-    optional bool protosizer_all = 63028;
-    optional bool compare_all = 63029;
-    optional bool typedecl_all = 63030;
-    optional bool enumdecl_all = 63031;
-
-    optional bool goproto_registration = 63032;
-    optional bool messagename_all = 63033;
-}
-
-extend google.protobuf.MessageOptions {
-    optional bool goproto_getters = 64001;
-    optional bool goproto_stringer = 64003;
-    optional bool verbose_equal = 64004;
-    optional bool face = 64005;
-    optional bool gostring = 64006;
-    optional bool populate = 64007;
-    optional bool stringer = 67008;
-    optional bool onlyone = 64009;
-
-    optional bool equal = 64013;
-    optional bool description = 64014;
-    optional bool testgen = 64015;
-    optional bool benchgen = 64016;
-    optional bool marshaler = 64017;
-    optional bool unmarshaler = 64018;
-    optional bool stable_marshaler = 64019;
-
-    optional bool sizer = 64020;
-
-    optional bool unsafe_marshaler = 64023;
-    optional bool unsafe_unmarshaler = 64024;
-
-    optional bool goproto_extensions_map = 64025;
-    optional bool goproto_unrecognized = 64026;
-
-    optional bool protosizer = 64028;
-    optional bool compare = 64029;
-
-    optional bool typedecl = 64030;
-
-    optional bool messagename = 64033;
-}
-
-extend google.protobuf.FieldOptions {
-    optional bool nullable = 65001;
-    optional bool embed = 65002;
-    optional string customtype = 65003;
-    optional string customname = 65004;
-    optional string jsontag = 65005;
-    optional string moretags = 65006;
-    optional string casttype = 65007;
-    optional string castkey = 65008;
-    optional string castvalue = 65009;
-
-    optional bool stdtime = 65010;
-    optional bool stdduration = 65011;
-}