You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/06/27 21:39:39 UTC

[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #1622: LUCENE-9420: update restlet version

MarcusSorealheis opened a new pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622


   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   CVEs in current version
   
   # Solution
   
   Upgrade the version to `2.4.3`
   
   # Tests
   
   Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `master` branch.
   - [ ] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1622: SOLR-14603: update Restlet version

Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622#issuecomment-650824077


   Everything is fine. I don't where I got those first checksums from. I don't recall specifying a different algorithm. :)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] MarcusSorealheis edited a comment on pull request #1622: LUCENE-9420: update restlet version [DRAFT]

Posted by GitBox <gi...@apache.org>.
MarcusSorealheis edited a comment on pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622#issuecomment-650637869


   > Need to update gradle build and sha files too :)
   
   I just read that I need to update checksums. On it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] janhoy commented on pull request #1622: LUCENE-9420: update restlet version [DRAFT]

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622#issuecomment-650637615


   Need to update gradle build and sha files too :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] MarcusSorealheis edited a comment on pull request #1622: SOLR-14603: update Restlet version

Posted by GitBox <gi...@apache.org>.
MarcusSorealheis edited a comment on pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622#issuecomment-650812066


   I think this is finally ready. @janhoy i need to dig into my OS’s crypto libraries.  I’m doing a final pass on those. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1622: LUCENE-9420: update restlet version [DRAFT]

Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622#issuecomment-650637869


   > Need to update gradle build and sha files too :)
   I just read that I need to update checksums. On it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] MarcusSorealheis edited a comment on pull request #1622: LUCENE-9420: update restlet version [DRAFT]

Posted by GitBox <gi...@apache.org>.
MarcusSorealheis edited a comment on pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622#issuecomment-650637869


   > Need to update gradle build and sha files too :)
   
   I just read that I need to update checksums. On it. Thanks for the heads up.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] MarcusSorealheis edited a comment on pull request #1622: SOLR-14603: update Restlet version

Posted by GitBox <gi...@apache.org>.
MarcusSorealheis edited a comment on pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622#issuecomment-650824077


   Everything is fine. I don't where I got those incorrect checksums from initially. I don't recall specifying a different algorithm. :)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1622: SOLR-14603: update Restlet version

Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622#issuecomment-650812066


   I think this finally ready. For some reason, my checksums locally were not working well. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] chatman commented on pull request #1622: SOLR-14603: update Restlet version

Posted by GitBox <gi...@apache.org>.
chatman commented on pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622#issuecomment-653735464


   +1, LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] chatman commented on pull request #1622: SOLR-14603: update Restlet version

Posted by GitBox <gi...@apache.org>.
chatman commented on pull request #1622:
URL: https://github.com/apache/lucene-solr/pull/1622#issuecomment-653857121


   This is merged. Please close the PR. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org