You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by pt...@apache.org on 2022/05/26 10:50:56 UTC
[ignite-3] branch ignite-14972 updated: wip TODOs
This is an automated email from the ASF dual-hosted git repository.
ptupitsyn pushed a commit to branch ignite-14972
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/ignite-14972 by this push:
new 0d58182c0 wip TODOs
0d58182c0 is described below
commit 0d58182c0a4f79236cbd60d7d2d3e9e13bb07f95
Author: Pavel Tupitsyn <pt...@apache.org>
AuthorDate: Thu May 26 13:50:50 2022 +0300
wip TODOs
---
.../ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java | 2 ++
1 file changed, 2 insertions(+)
diff --git a/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java b/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
index 2034a6cea..191922a72 100644
--- a/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
+++ b/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
@@ -62,6 +62,8 @@ public class ClientSqlExecuteRequest {
sessionBuilder.property(in.unpackString(), in.unpackObjectWithType());
}
+ // TODO: Session must be somehow stored on the server, to be able to close it and clean up.
+ // So build call on the client must perform a network call.
Session session = sessionBuilder.build();
// TODO: should we store prepared statements per connection? - separate ticket.