You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/17 23:54:48 UTC

[GitHub] [nifi-minifi-cpp] szaszm edited a comment on pull request #992: MINIFICPP-1467 Remove mutex from Connection

szaszm edited a comment on pull request #992:
URL: https://github.com/apache/nifi-minifi-cpp/pull/992#issuecomment-780928820


   About exposing internals: I don't think it's happening here. I view `LockedConcurrentQueue` as an implementation detail of `ConcurrentQueue`, so they are one unit, even though they are syntactically implemented as two classes. To make this clear, maybe it could be hidden in a `detail` namespace and not allow client code to name it.
   
   I like the design, but on the flipside, it introduces more complexity than it removes. Overall, I support this change. If we happen to reuse this change at least once more, then the introduced complexity would pay off.
   
   Let's wait for more opinions!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org