You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/12/19 07:28:18 UTC
Review Request 16362: CLOUDSTACK-5554: Custom disk offering allows to create
a datadisk with size greater than custom.diskoffering.size.max value
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/
-----------------------------------------------------------
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-5554
https://issues.apache.org/jira/browse/CLOUDSTACK-5554
Repository: cloudstack-git
Description
-------
CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
Moved both parameters to VolumeOrchestrationService using ConfigDepot
Diffs
-----
engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java 1bba479
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 41a3f29
server/src/com/cloud/configuration/Config.java b994ce3
server/src/com/cloud/server/ManagementServerImpl.java 0e9c483
server/src/com/cloud/storage/VolumeApiServiceImpl.java 264f2bd
server/src/com/cloud/vm/UserVmManagerImpl.java 74b3439
setup/db/db/schema-421to430.sql d9cdfe6
Diff: https://reviews.apache.org/r/16362/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 16362: CLOUDSTACK-5554: Custom disk offering allows to
create a datadisk with size greater than custom.diskoffering.size.max value
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/#review30684
-----------------------------------------------------------
Commit 1c6b146d0421ef66be1015d9f422274cea741ce3 in branch refs/heads/4.3 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1c6b146 ]
CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
- ASF Subversion and Git Services
On Dec. 19, 2013, 6:56 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16362/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 6:56 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-5554
> https://issues.apache.org/jira/browse/CLOUDSTACK-5554
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
> Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
>
> Moved both parameters to VolumeOrchestrationService using ConfigDepot
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java 1bba479
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ebd8709
> server/src/com/cloud/configuration/Config.java 4da7e58
> server/src/com/cloud/server/ManagementServerImpl.java 8dad7ae
> server/src/com/cloud/storage/VolumeApiServiceImpl.java dd6358a
> server/src/com/cloud/vm/UserVmManagerImpl.java 74b3439
> setup/db/db/schema-421to430.sql 9913b08
>
> Diff: https://reviews.apache.org/r/16362/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 16362: CLOUDSTACK-5554: Custom disk offering allows to
create a datadisk with size greater than custom.diskoffering.size.max value
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/#review30700
-----------------------------------------------------------
Commit c39431ff6a1d10a5d4c278418ff7198edd8903f5 in branch refs/heads/4.3 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c39431f ]
CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
- ASF Subversion and Git Services
On Dec. 19, 2013, 10:27 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16362/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 10:27 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-5554
> https://issues.apache.org/jira/browse/CLOUDSTACK-5554
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
> Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
>
> Moved both parameters to VolumeOrchestrationService using ConfigDepot
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a9ccc06
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java efaa288
> server/src/com/cloud/configuration/Config.java 3893c2f
> server/src/com/cloud/server/ManagementServerImpl.java 8bc095d
> server/src/com/cloud/storage/VolumeApiServiceImpl.java 2fa023e
> server/src/com/cloud/vm/UserVmManagerImpl.java 3ad49d8
> setup/db/db/schema-421to430.sql ba19ae6
>
> Diff: https://reviews.apache.org/r/16362/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 16362: CLOUDSTACK-5554: Custom disk offering allows to
create a datadisk with size greater than custom.diskoffering.size.max value
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/#review30701
-----------------------------------------------------------
Commit 227567cf6ca79c7bc398b55f2eee4d8fb93c0de4 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=227567c ]
CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
- ASF Subversion and Git Services
On Dec. 19, 2013, 10:27 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16362/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 10:27 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-5554
> https://issues.apache.org/jira/browse/CLOUDSTACK-5554
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
> Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
>
> Moved both parameters to VolumeOrchestrationService using ConfigDepot
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a9ccc06
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java efaa288
> server/src/com/cloud/configuration/Config.java 3893c2f
> server/src/com/cloud/server/ManagementServerImpl.java 8bc095d
> server/src/com/cloud/storage/VolumeApiServiceImpl.java 2fa023e
> server/src/com/cloud/vm/UserVmManagerImpl.java 3ad49d8
> setup/db/db/schema-421to430.sql ba19ae6
>
> Diff: https://reviews.apache.org/r/16362/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 16362: CLOUDSTACK-5554: Custom disk offering allows to
create a datadisk with size greater than custom.diskoffering.size.max value
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/#review30688
-----------------------------------------------------------
Commit 707da55fe3f94e95ee0186fd119f78d1d3def5c7 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=707da55 ]
CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
Moved both parameters to VolumeOrchestrationService using ConfigDepot
- ASF Subversion and Git Services
On Dec. 19, 2013, 10:27 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16362/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 10:27 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-5554
> https://issues.apache.org/jira/browse/CLOUDSTACK-5554
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
> Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
>
> Moved both parameters to VolumeOrchestrationService using ConfigDepot
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a9ccc06
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java efaa288
> server/src/com/cloud/configuration/Config.java 3893c2f
> server/src/com/cloud/server/ManagementServerImpl.java 8bc095d
> server/src/com/cloud/storage/VolumeApiServiceImpl.java 2fa023e
> server/src/com/cloud/vm/UserVmManagerImpl.java 3ad49d8
> setup/db/db/schema-421to430.sql ba19ae6
>
> Diff: https://reviews.apache.org/r/16362/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 16362: CLOUDSTACK-5554: Custom disk offering allows to
create a datadisk with size greater than custom.diskoffering.size.max value
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 10:27 a.m.)
Review request for cloudstack and Kishan Kavala.
Changes
-------
Updated the patch to apply on master
Bugs: CLOUDSTACK-5554
https://issues.apache.org/jira/browse/CLOUDSTACK-5554
Repository: cloudstack-git
Description
-------
CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
Moved both parameters to VolumeOrchestrationService using ConfigDepot
Diffs (updated)
-----
engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a9ccc06
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java efaa288
server/src/com/cloud/configuration/Config.java 3893c2f
server/src/com/cloud/server/ManagementServerImpl.java 8bc095d
server/src/com/cloud/storage/VolumeApiServiceImpl.java 2fa023e
server/src/com/cloud/vm/UserVmManagerImpl.java 3ad49d8
setup/db/db/schema-421to430.sql ba19ae6
Diff: https://reviews.apache.org/r/16362/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 16362: CLOUDSTACK-5554: Custom disk offering allows to
create a datadisk with size greater than custom.diskoffering.size.max value
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/#review30687
-----------------------------------------------------------
Ship it!
1c6b146d0421ef66be1015d9f422274cea741ce3
- Kishan Kavala
On Dec. 19, 2013, 12:26 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16362/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 12:26 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-5554
> https://issues.apache.org/jira/browse/CLOUDSTACK-5554
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
> Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
>
> Moved both parameters to VolumeOrchestrationService using ConfigDepot
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java 1bba479
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ebd8709
> server/src/com/cloud/configuration/Config.java 4da7e58
> server/src/com/cloud/server/ManagementServerImpl.java 8dad7ae
> server/src/com/cloud/storage/VolumeApiServiceImpl.java dd6358a
> server/src/com/cloud/vm/UserVmManagerImpl.java 74b3439
> setup/db/db/schema-421to430.sql 9913b08
>
> Diff: https://reviews.apache.org/r/16362/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 16362: CLOUDSTACK-5554: Custom disk offering allows to
create a datadisk with size greater than custom.diskoffering.size.max value
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 6:56 a.m.)
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-5554
https://issues.apache.org/jira/browse/CLOUDSTACK-5554
Repository: cloudstack-git
Description
-------
CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
Moved both parameters to VolumeOrchestrationService using ConfigDepot
Diffs (updated)
-----
engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java 1bba479
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ebd8709
server/src/com/cloud/configuration/Config.java 4da7e58
server/src/com/cloud/server/ManagementServerImpl.java 8dad7ae
server/src/com/cloud/storage/VolumeApiServiceImpl.java dd6358a
server/src/com/cloud/vm/UserVmManagerImpl.java 74b3439
setup/db/db/schema-421to430.sql 9913b08
Diff: https://reviews.apache.org/r/16362/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 16362: CLOUDSTACK-5554: Custom disk offering allows to
create a datadisk with size greater than custom.diskoffering.size.max value
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 6:40 a.m.)
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-5554
https://issues.apache.org/jira/browse/CLOUDSTACK-5554
Repository: cloudstack-git
Description
-------
CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value
Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
Moved both parameters to VolumeOrchestrationService using ConfigDepot
Diffs (updated)
-----
engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java 1bba479
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 41a3f29
server/src/com/cloud/configuration/Config.java b994ce3
server/src/com/cloud/server/ManagementServerImpl.java 0e9c483
server/src/com/cloud/storage/VolumeApiServiceImpl.java 264f2bd
server/src/com/cloud/vm/UserVmManagerImpl.java 74b3439
setup/db/db/schema-421to430.sql d9cdfe6
Diff: https://reviews.apache.org/r/16362/diff/
Testing
-------
Thanks,
Harikrishna Patnala