You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Chris Love (JIRA)" <ji...@apache.org> on 2009/11/18 02:07:52 UTC
[jira] Created: (CAMEL-2189) Improvment in example archtypes
Improvment in example archtypes
-------------------------------
Key: CAMEL-2189
URL: https://issues.apache.org/activemq/browse/CAMEL-2189
Project: Apache Camel
Issue Type: Improvement
Components: tooling
Affects Versions: 2.2.0
Reporter: Chris Love
Priority: Minor
Fix For: 2.2.0
Attachments: camel-archetypes.patch
Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2189) Improvment in example archtypes
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55522#action_55522 ]
Hadrian Zbarcea commented on CAMEL-2189:
----------------------------------------
Chris, thanks for the patch. What was the reason for replacing the .properties with .xml files? I also see that you use tabs for indentation, and we prefer spaces.
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.2.0
> Reporter: Chris Love
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: camel-archetypes.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2189) Improvment in example
archtypes
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55548#action_55548 ]
Hadrian Zbarcea edited comment on CAMEL-2189 at 11/18/09 6:59 AM:
------------------------------------------------------------------
Chris, now I understand. The mere fact though that you can validate xml doesn't necessarily mean that it contains what you want. In this sense the validation is of little value for me. As Claus said, we prefer the simplicity of the .properties files.
That said, Camel is built by the community for the community. If you really feel strongly about this issue, and think you can make a solid case feel, free to bring it in the open and start a [DISCUSS] thread on the dev@ mailing list. If the majority will share your views we will make such a change. Personally I am a -0.5 on this, so I will not start such a thread myself :).
I will have to take a closer look at the other part of the patch. Many thanks for your contribution and keep them coming.
was (Author: hadrian):
Chris, now I understand. The mere fact though that you can validate xml doesn't necessarily meant that it contains what you want. In this sense the validation is of little value for me. As Claus said, we prefer the simplicity of the .properties files.
That said, Camel is built by the community for the community. If you really feel strongly about this issue, and think you can make a solid case feel, free to bring it in the open and start a [DISCUSS] thread on the dev@ mailing list. If the majority will share your views we will make such a change. Personally I am a -0.5 on this, so I will not start such a thread myself :).
I will have to take a closer look at the other part of the patch. Many thanks for your contribution and keep them coming.
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.2.0
> Reporter: Chris Love
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: camel-archetypes.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2189) Improvment in example archtypes
Posted by "Chris Love (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Love updated CAMEL-2189:
------------------------------
Attachment: camel-patch-app-context.patch
only app context files. Using spaces.
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.2.0
> Reporter: Chris Love
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: camel-archetypes.patch, camel-patch-app-context.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2189) Improvment in example archtypes
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55528#action_55528 ]
Claus Ibsen commented on CAMEL-2189:
------------------------------------
Yeah we prefer to use properties files for log4j. Its much easier to use, understand and maintain.
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.2.0
> Reporter: Chris Love
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: camel-archetypes.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2189) Improvment in example archtypes
Posted by "Chris Love (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Love updated CAMEL-2189:
------------------------------
Attachment: camel-archetypes.patch
Patch for archtype changes
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.2.0
> Reporter: Chris Love
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: camel-archetypes.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2189) Improvment in example archtypes
Posted by "Chris Love (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55527#action_55527 ]
Chris Love commented on CAMEL-2189:
-----------------------------------
XML can be validated, but hey to each there own :) yah I need to fix that in my vim profile to do spaces ;)
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.2.0
> Reporter: Chris Love
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: camel-archetypes.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2189) Improvment in example archtypes
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea resolved CAMEL-2189.
------------------------------------
Resolution: Fixed
Patch applied with thanks to Chris.
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.0.0
> Reporter: Chris Love
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: camel-archetypes.patch, camel-patch-app-context.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2189) Improvment in example archtypes
Posted by "Chris Love (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55568#action_55568 ]
Chris Love commented on CAMEL-2189:
-----------------------------------
No worries on the log4j file. I am here to help. I have uploaded a new patch that only has the application context changes using spaces instead of tabs. BTW does camel have a style guide??
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.2.0
> Reporter: Chris Love
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: camel-archetypes.patch, camel-patch-app-context.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2189) Improvment in example archtypes
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea reassigned CAMEL-2189:
--------------------------------------
Assignee: Hadrian Zbarcea
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.2.0
> Reporter: Chris Love
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: camel-archetypes.patch, camel-patch-app-context.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2189) Improvment in example archtypes
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55548#action_55548 ]
Hadrian Zbarcea commented on CAMEL-2189:
----------------------------------------
Chris, now I understand. The mere fact though that you can validate xml doesn't necessarily meant that it contains what you want. In this sense the validation is of little value for me. As Claus said, we prefer the simplicity of the .properties files.
That said, Camel is built by the community for the community. If you really feel strongly about this issue, and think you can make a solid case feel, free to bring it in the open and start a [DISCUSS] thread on the dev@ mailing list. If the majority will share your views we will make such a change. Personally I am a -0.5 on this, so I will not start such a thread myself :).
I will have to take a closer look at the other part of the patch. Many thanks for your contribution and keep them coming.
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.2.0
> Reporter: Chris Love
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: camel-archetypes.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2189) Improvment in example archtypes
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea updated CAMEL-2189:
-----------------------------------
Affects Version/s: (was: 2.2.0)
2.0.0
Fix Version/s: (was: 2.2.0)
2.1.0
> Improvment in example archtypes
> -------------------------------
>
> Key: CAMEL-2189
> URL: https://issues.apache.org/activemq/browse/CAMEL-2189
> Project: Apache Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.0.0
> Reporter: Chris Love
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: camel-archetypes.patch, camel-patch-app-context.patch
>
>
> Made changes to improve application context xml to improve schema usage. Also replaced log4j.properties fles with log4j.xml files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.