You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/12 01:30:41 UTC
[GitHub] [incubator-seatunnel] yx91490 opened a new pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
yx91490 opened a new pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
close #1021
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1014102939
hi @yx91490, let's imagine a scenario, if flink-console and flink-doris module references the same dependency called `log-xx` dependency, flink-console requires `log-xx.1.2.0`, but flink-doris requires `log-xx.1.5.0`. In this scenario, we need the shade plugin.
BTW, seatunnel has many connectors, maven-shade-plugin is useful for each module when meets conflict.
```
[dcadmin@dcadmin seatunnel-connectors]$ du -chs *
4.0K pom.xml
1.5M seatunnel-connector-flink-console
1.8M seatunnel-connector-flink-doris
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1014102939
hi @yx91490, let's imagine a scenario, if `flink-console` and `flink-doris` module references the same dependency called `log-xx` dependency, `flink-console` requires `log-xx.1.2.0`, but `flink-doris` requires `log-xx.1.5.0`. In this scenario, we need the shade plugin.
BTW, seatunnel has many connectors, maven-shade-plugin is useful for each module when meets conflict.
```
[dcadmin@dcadmin seatunnel-connectors]$ du -chs *
4.0K pom.xml
1.5M seatunnel-connector-flink-console
1.8M seatunnel-connector-flink-doris
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1011828596
em.. it seems will cause bug, `transforms` `connectors` only contain itself.
```
[dcadmin@dcadmin seatunnel-connectors]$ du -chs *
4.0K pom.xml
1.5M seatunnel-connector-flink-console
1.8M seatunnel-connector-flink-doris
1.8M seatunnel-connector-flink-druid
1.6M seatunnel-connector-flink-elasticsearch
1.5M seatunnel-connector-flink-fake
2.0M seatunnel-connector-flink-file
1.6M seatunnel-connector-flink-jdbc
1.6M seatunnel-connector-flink-kafka
1.5M seatunnel-connector-flink-socket
1.7M seatunnel-connector-spark-clickhouse
1.5M seatunnel-connector-spark-console
1.7M seatunnel-connector-spark-doris
1.6M seatunnel-connector-spark-elasticsearch
2.5M seatunnel-connector-spark-email
1.6M seatunnel-connector-spark-fake
1.7M seatunnel-connector-spark-file
1.6M seatunnel-connector-spark-hbase
1.6M seatunnel-connector-spark-hive
1.6M seatunnel-connector-spark-hudi
3.2M seatunnel-connector-spark-jdbc
1.8M seatunnel-connector-spark-kafka
1.6M seatunnel-connector-spark-kudu
1.5M seatunnel-connector-spark-mongodb
2.2M seatunnel-connector-spark-phoenix
1.8M seatunnel-connector-spark-redis
1.5M seatunnel-connector-spark-socket
```
### Missing dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1014102939
hi @yx91490, let's imagine a scenario, if `flink-console` and `flink-doris` module references the same dependency called `log-xx` dependency, flink-console requires `log-xx.1.2.0`, but flink-doris requires `log-xx.1.5.0`. In this scenario, we need the shade plugin.
BTW, seatunnel has many connectors, maven-shade-plugin is useful for each module when meets conflict.
```
[dcadmin@dcadmin seatunnel-connectors]$ du -chs *
4.0K pom.xml
1.5M seatunnel-connector-flink-console
1.8M seatunnel-connector-flink-doris
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1014102939
hi @yx91490, let's imagine a scenario, if `flink-console` and `flink-doris` module references the same dependency called `log-xx` dependency, flink-console` requires `log-xx.1.2.0`, but `flink-doris` requires `log-xx.1.5.0`. In this scenario, we need the shade plugin.
BTW, seatunnel has many connectors, maven-shade-plugin is useful for each module when meets conflict.
```
[dcadmin@dcadmin seatunnel-connectors]$ du -chs *
4.0K pom.xml
1.5M seatunnel-connector-flink-console
1.8M seatunnel-connector-flink-doris
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1011828596
em.. it seems will cause bug, `transforms` `connectors` only contain itself.
```
[dcadmin@dcadmin seatunnel-connectors]$ du -chs *
4.0K pom.xml
1.5M seatunnel-connector-flink-console
1.8M seatunnel-connector-flink-doris
1.8M seatunnel-connector-flink-druid
1.6M seatunnel-connector-flink-elasticsearch
1.5M seatunnel-connector-flink-fake
2.0M seatunnel-connector-flink-file
1.6M seatunnel-connector-flink-jdbc
1.6M seatunnel-connector-flink-kafka
1.5M seatunnel-connector-flink-socket
1.7M seatunnel-connector-spark-clickhouse
1.5M seatunnel-connector-spark-console
```
### Missing dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] an-shi-chi-fan commented on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
an-shi-chi-fan commented on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1011049700
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
yx91490 commented on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1012647336
> em.. it seems will cause bug, `transforms` `connectors` only contain itself.
>
> ```
> [dcadmin@dcadmin seatunnel-connectors]$ du -chs *
> 4.0K pom.xml
> 1.5M seatunnel-connector-flink-console
> 1.8M seatunnel-connector-flink-doris
> 1.8M seatunnel-connector-flink-druid
> 1.6M seatunnel-connector-flink-elasticsearch
> 1.5M seatunnel-connector-flink-fake
> 2.0M seatunnel-connector-flink-file
> 1.6M seatunnel-connector-flink-jdbc
> 1.6M seatunnel-connector-flink-kafka
> 1.5M seatunnel-connector-flink-socket
> 1.7M seatunnel-connector-spark-clickhouse
> 1.5M seatunnel-connector-spark-console
> ```
>
> ### Missing dependencies
> 
Currently, it seems that plugins no need to package dependencies, they will be all packaged to a single jar by maven-shade-plugin finally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1011042911
@leo65535 PTAL,Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
yx91490 commented on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1014165806
> hi @yx91490, let's imagine a scenario, if flink-console and flink-doris module references the same dependency called `log-xx` dependency, flink-console requires `log-xx.1.2.0`, but flink-doris requires `log-xx.1.5.0`. In this scenario, we need the shade plugin. BTW, seatunnel has many connectors, maven-shade-plugin is useful for each module when meets conflict.
>
> ```
> [dcadmin@dcadmin seatunnel-connectors]$ du -chs *
> 4.0K pom.xml
> 1.5M seatunnel-connector-flink-console
> 1.8M seatunnel-connector-flink-doris
> ```
make sense, but in this scenario you should configure maven-shade-plugin with `relocations`, but currently no plugin module configured `relocations`, that is , currently maven-shade-plugin only used to package to a single jar, no other effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1011683790
hi @yx91490, `seatunnel-core-sql` also need `maven-shade-plugin`, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1022: [SeaTunnel#1021] make maven-shade-plugin only applied to core modules
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1022:
URL: https://github.com/apache/incubator-seatunnel/pull/1022#issuecomment-1014244089
You are quite right. It seems not necessary to make the change currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org