You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Luc Maisonobe (JIRA)" <ji...@apache.org> on 2011/05/09 20:02:03 UTC
[jira] [Commented] (MATH-570) Change some constructors of
ArrayFieldVector to accept FieldVector
[ https://issues.apache.org/jira/browse/MATH-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030835#comment-13030835 ]
Luc Maisonobe commented on MATH-570:
------------------------------------
The purpose of the large number of constructors is precisely to avoid spurious copies.
So I would consider their existence as a feature.
> Change some constructors of ArrayFieldVector to accept FieldVector
> ------------------------------------------------------------------
>
> Key: MATH-570
> URL: https://issues.apache.org/jira/browse/MATH-570
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Arne Plöse
> Priority: Minor
>
> the constructor public ArrayFieldVector(T[] v1, ArrayFieldVector<T> v2) {
> ...
> }
> takes an ArrayFieldVector.
> but the same can be easier archieved with this
> public ArrayFieldVector(T[] v1, FieldVector<T> v2) {
> this(v1, v2 == null ? null : v2.getData());
> }
> this goes for all other constructors...
> P.S. I donk know if copying the data in getData is an issue ... for this the named constructor may make sense...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira