You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "xcsnx (via GitHub)" <gi...@apache.org> on 2023/09/09 03:11:01 UTC

[GitHub] [shenyu] xcsnx opened a new pull request, #5133: [type:feat]shenyu-client add discovery config registration

xcsnx opened a new pull request, #5133:
URL: https://github.com/apache/shenyu/pull/5133

   <!-- Describe your PR here; eg. Fixes #issueNo -->
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shenyu] codecov-commenter commented on pull request #5133: [type:feat]shenyu-client add discovery config registration

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5133:
URL: https://github.com/apache/shenyu/pull/5133#issuecomment-1715690237

   ## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#5133](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8c02155) into [master](https://app.codecov.io/gh/apache/shenyu/commit/5c561d98ec02da2e8b952c119286e5cd98bdb873?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5c561d9) will **decrease** coverage by `0.04%`.
   > The diff coverage is `4.16%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5133      +/-   ##
   ============================================
   - Coverage     61.10%   61.07%   -0.04%     
   - Complexity     8471     8473       +2     
   ============================================
     Files          1242     1243       +1     
     Lines         37342    37366      +24     
     Branches       3523     3524       +1     
   ============================================
   + Hits          22817    22820       +3     
   - Misses        12562    12584      +22     
   + Partials       1963     1962       -1     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...controller/ShenyuClientHttpRegistryController.java](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVDbGllbnRIdHRwUmVnaXN0cnlDb250cm9sbGVyLmphdmE=) | `50.00% <0.00%> (-3.85%)` | :arrow_down: |
   | [.../client/AbstractContextRefreshedEventListener.java](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9jbGllbnQvQWJzdHJhY3RDb250ZXh0UmVmcmVzaGVkRXZlbnRMaXN0ZW5lci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../disruptor/ShenyuClientRegisterEventPublisher.java](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9kaXNydXB0b3IvU2hlbnl1Q2xpZW50UmVnaXN0ZXJFdmVudFB1Ymxpc2hlci5qYXZh) | `14.28% <0.00%> (-1.10%)` | :arrow_down: |
   | [...ShenyuClientDiscoveryConfigExecutorSubscriber.java](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9kaXNydXB0b3Ivc3ViY3JpYmVyL1NoZW55dUNsaWVudERpc2NvdmVyeUNvbmZpZ0V4ZWN1dG9yU3Vic2NyaWJlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...egister/ShenyuClientRegisterRepositoryFactory.java](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9TaGVueXVDbGllbnRSZWdpc3RlclJlcG9zaXRvcnlGYWN0b3J5LmphdmE=) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/shenyu/common/constant/Constants.java](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | `83.33% <ø> (ø)` | |
   | [...ster/client/http/HttpClientRegisterRepository.java](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3JlZ2lzdGVyL2NsaWVudC9odHRwL0h0dHBDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...on/config/ShenyuClientCommonBeanConfiguration.java](https://app.codecov.io/gh/apache/shenyu/pull/5133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItY2xpZW50L3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLWNsaWVudC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zcHJpbmdib290L3N0YXJ0ZXIvY2xpZW50L2NvbW1vbi9jb25maWcvU2hlbnl1Q2xpZW50Q29tbW9uQmVhbkNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | |
   
   ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5133/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shenyu] xcsnx commented on pull request #5133: [type:feat]shenyu-client add discovery config registration

Posted by "xcsnx (via GitHub)" <gi...@apache.org>.
xcsnx commented on PR #5133:
URL: https://github.com/apache/shenyu/pull/5133#issuecomment-1712400535

   Not Completed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shenyu] xcsnx closed pull request #5133: [type:feat]shenyu-client add discovery config registration

Posted by "xcsnx (via GitHub)" <gi...@apache.org>.
xcsnx closed pull request #5133: [type:feat]shenyu-client add discovery config registration
URL: https://github.com/apache/shenyu/pull/5133


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org