You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ratis.apache.org by sz...@apache.org on 2025/10/03 10:39:31 UTC
(ratis) branch master updated: RATIS-2342. Remove NIO specification from GrpcStubPool. (#1297)
This is an automated email from the ASF dual-hosted git repository.
szetszwo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ratis.git
The following commit(s) were added to refs/heads/master by this push:
new 047444b06 RATIS-2342. Remove NIO specification from GrpcStubPool. (#1297)
047444b06 is described below
commit 047444b06f39b30852da56b15136c2e47f5ab22c
Author: Symious <14...@users.noreply.github.com>
AuthorDate: Fri Oct 3 18:39:26 2025 +0800
RATIS-2342. Remove NIO specification from GrpcStubPool. (#1297)
---
.../main/java/org/apache/ratis/grpc/server/GrpcStubPool.java | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcStubPool.java b/ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcStubPool.java
index c949707a4..55a1c6d35 100644
--- a/ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcStubPool.java
+++ b/ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcStubPool.java
@@ -24,8 +24,6 @@ import org.apache.ratis.thirdparty.io.grpc.netty.NettyChannelBuilder;
import org.apache.ratis.thirdparty.io.grpc.stub.AbstractStub;
import org.apache.ratis.thirdparty.io.netty.channel.ChannelOption;
import org.apache.ratis.thirdparty.io.netty.channel.WriteBufferWaterMark;
-import org.apache.ratis.thirdparty.io.netty.channel.nio.NioEventLoopGroup;
-import org.apache.ratis.thirdparty.io.netty.channel.socket.nio.NioSocketChannel;
import org.apache.ratis.thirdparty.io.netty.handler.ssl.SslContext;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -62,21 +60,17 @@ final class GrpcStubPool<S extends AbstractStub<S>> {
}
private final List<PooledStub<S>> pool;
- private final NioEventLoopGroup elg;
private final int size;
GrpcStubPool(RaftPeer target, int n, Function<ManagedChannel, S> stubFactory, SslContext sslContext) {
- this(target, n, stubFactory, sslContext, Math.max(2, Runtime.getRuntime().availableProcessors() / 2), 16);
+ this(target, n, stubFactory, sslContext, 16);
}
GrpcStubPool(RaftPeer target, int n, Function<ManagedChannel, S> stubFactory, SslContext sslContext,
- int elgThreads, int maxInflightPerConn) {
- this.elg = new NioEventLoopGroup(elgThreads);
+ int maxInflightPerConn) {
ArrayList<PooledStub<S>> tmp = new ArrayList<>(n);
for (int i = 0; i < n; i++) {
NettyChannelBuilder channelBuilder = NettyChannelBuilder.forTarget(target.getAddress())
- .eventLoopGroup(elg)
- .channelType(NioSocketChannel.class)
.keepAliveTime(30, TimeUnit.SECONDS)
.keepAliveWithoutCalls(true)
.idleTimeout(24, TimeUnit.HOURS)
@@ -112,6 +106,5 @@ final class GrpcStubPool<S extends AbstractStub<S>> {
for (PooledStub<S> p : pool) {
p.ch.shutdown();
}
- elg.shutdownGracefully();
}
}