[jira] [Created] (MESOS-659) The Master incorrectly sends a "Framework failed over" message when the scheduler driver retries an initial failover re-registration.

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

Benjamin Mahler created MESOS-659:
-------------------------------------

             Summary: The Master incorrectly sends a "Framework failed over" message when the scheduler driver retries an initial failover re-registration.
                 Key: MESOS-659
                 URL: https://issues.apache.org/jira/browse/MESOS-659
             Project: Mesos
          Issue Type: Bug
            Reporter: Benjamin Mahler
            Assignee: Benjamin Mahler


This bug can cause unnecessary additional failovers, if say, the master is delayed processing a re-registration attempt from a scheduler.

// Replace the scheduler for a framework with a new process ID, in the
// event of a scheduler failover.
void Master::failoverFramework(Framework* framework, const UPID& newPid)
{
  const UPID& oldPid = framework->pid;

  /** NEED TO GUARD AGAINST newPid == oldPid FOR RETRIES! */
  {
    FrameworkErrorMessage message;
    message.set_message("Framework failed over");
    send(oldPid, message);
  }
  ...
}

Sending the FrameworkErrorMessage here always is incorrect, we should not be sending it when the scheduler driver is simply re-trying the initial failover re-registration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira