You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "sksDonni (via GitHub)" <gi...@apache.org> on 2024/03/13 20:53:28 UTC
[PR] changed name of children route used for default/notfound route [skywalking-banyandb]
sksDonni opened a new pull request, #411:
URL: https://github.com/apache/skywalking-banyandb/pull/411
Fix https://github.com/apache/skywalking/issues/12007
Properties page not loading up
- [ ] Add a unit test to verify that the fix works.
- [X] Explain briefly why the bug exists and how to fix it.
The issue was caused due to the use of `property` keyword in the name parameter of route used for not found pages.
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [X] If it's UI related, attach the screenshots below.
https://github.com/apache/skywalking-banyandb/assets/53624363/99f4725b-e64e-4ce2-a980-7b5c8821edba
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] changed name of children route used for default/notfound route [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #411:
URL: https://github.com/apache/skywalking-banyandb/pull/411#issuecomment-1996190410
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/411?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 48.14%. Comparing base [(`64b0817`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/64b0817c137c4111211c13e56a5bdbb0bedfe5a0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`85dd68e`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/411?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #411 +/- ##
==========================================
- Coverage 48.55% 48.14% -0.42%
==========================================
Files 173 173
Lines 21592 21592
==========================================
- Hits 10485 10396 -89
- Misses 10207 10312 +105
+ Partials 900 884 -16
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/411?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] changed name of children route used for default/notfound route [skywalking-banyandb]
Posted by "sksDonni (via GitHub)" <gi...@apache.org>.
sksDonni commented on PR #411:
URL: https://github.com/apache/skywalking-banyandb/pull/411#issuecomment-1995778910
@hanahmily @wu-sheng @sivasathyaseeelan Can you please review the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] changed name of children route used for default/notfound route [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #411:
URL: https://github.com/apache/skywalking-banyandb/pull/411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org