[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #212: Enable IT for H2 Protocol Negotiation

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #212:
URL: https://github.com/apache/httpcomponents-core/pull/212#discussion_r465716829



##########
File path: httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/H2ProtocolNegotiationTest.java
##########
@@ -233,7 +233,7 @@ public void testNegotiateProtocol() throws Exception {
         final HttpResponse response1 = message1.getHead();
         Assert.assertThat(response1.getCode(), CoreMatchers.equalTo(HttpStatus.SC_OK));
 
-        if (javaVersion >= 9) {
+        if (javaVersion >= 8) {

Review comment:
       @michael-o This is the reason I have not enabled ALPN tests on Java 1.8. I could not find a reliable way of finding out the exact build number to make the test dependent on it. It is not worth it. Please close the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org