You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Gabor Kaszab (Code Review)" <ge...@cloudera.org> on 2019/08/06 12:05:37 UTC

[Impala-ASF-CR] IMPALA-8600 AnalyzerTest.TestAnalyzeTransactiona() test fix

Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14017


Change subject: IMPALA-8600 AnalyzerTest.TestAnalyzeTransactiona() test fix
......................................................................

IMPALA-8600 AnalyzerTest.TestAnalyzeTransactiona() test fix

Adjusts expected error message in
AnalyzerTest.TestAnalyzeTransactional() after rewriting the message.

Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
---
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/14017/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>

[Impala-ASF-CR] IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14017 )

Change subject: IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix
......................................................................

IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix

Adjusts expected error message in
AnalyzerTest.TestAnalyzeTransactional() after rewriting the message.

Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Reviewed-on: http://gerrit.cloudera.org:8080/14017
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 5
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8600 AnalyzerTest.TestAnalyzeTransactional() test fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14017 )

Change subject: IMPALA-8600 AnalyzerTest.TestAnalyzeTransactional() test fix
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4150/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 12:47:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8600 AnalyzerTest.TestAnalyzeTransactional() test fix

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14017 )

Change subject: IMPALA-8600 AnalyzerTest.TestAnalyzeTransactional() test fix
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14017/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14017/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-8600 AnalyzerTest.TestAnalyzeTransactional() test fix
nit: please add : for consistency with other commits



-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 12:43:05 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.

Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14017 )

Change subject: IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix
......................................................................


Patch Set 3:

(1 comment)

Thanks Csaba! Carrying your +2

http://gerrit.cloudera.org:8080/#/c/14017/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14017/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix
> nit: please add : for consistency with other commits
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 12:57:41 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14017 )

Change subject: IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 17:48:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14017 )

Change subject: IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 12:57:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.

Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14017

to look at the new patch set (#3).

Change subject: IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix
......................................................................

IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix

Adjusts expected error message in
AnalyzerTest.TestAnalyzeTransactional() after rewriting the message.

Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
---
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/14017/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8600 AnalyzerTest.TestAnalyzeTransactional() test fix

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14017

to look at the new patch set (#2).

Change subject: IMPALA-8600 AnalyzerTest.TestAnalyzeTransactional() test fix
......................................................................

IMPALA-8600 AnalyzerTest.TestAnalyzeTransactional() test fix

Adjusts expected error message in
AnalyzerTest.TestAnalyzeTransactional() after rewriting the message.

Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
---
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/14017/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.

Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14017 )

Change subject: IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 12:57:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14017 )

Change subject: IMPALA-8600: AnalyzerTest.TestAnalyzeTransactional() test fix
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4738/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f1ed5da8cd3511eae4db12fb5ce1235aee50fd6
Gerrit-Change-Number: 14017
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 12:58:01 +0000
Gerrit-HasComments: No