You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/03/20 10:53:08 UTC

[Bug 56293] New: WebappClassLoader does not cache META-INF/services which leads to performance issues

https://issues.apache.org/bugzilla/show_bug.cgi?id=56293

            Bug ID: 56293
           Summary: WebappClassLoader does not cache META-INF/services
                    which leads to performance issues
           Product: Tomcat 7
           Version: 7.0.28
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: michael.thiele@saxsys.de

Since Tomcat 7.0.28, the WebappClassLoader does not cache any resources on the
classpath except .class and .properties files (see
https://issues.apache.org/bugzilla/show_bug.cgi?id=53081).
This leads to a massive performance problem in applications that contain .jars
on the classpath that use the ServiceLoader mechanism of Java 6 to bind
concrete XML readers and writers to their respective interfaces, since every
time the concrete instance is loaded, the WebappClassLoader has to open the
.jar to read which concrete implementation is used.
A possible solution might be that caching is enabled for all resources that
reside in the META-INF/services folder.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56293] WebappClassLoader does not cache META-INF/services which leads to performance issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56293

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Thanks for the test case. It appears that the ServiceLoader code isn't used and
it is clear that the code path where caching was removed is used.

I agree that caching the contents META-INF/services id probably the way to go
but I think there will need to be some form of limit just in case there is a
large file there for some strange reason. I'm looking into a fix now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56293] WebappClassLoader does not cache META-INF/services which leads to performance issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56293

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Mark Thomas <ma...@apache.org> ---
This has been fixed in 8.0.x for 8.0.5 onwards and in 7.0.x for 7.0.53 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56293] WebappClassLoader does not cache META-INF/services which leads to performance issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56293

--- Comment #2 from Michael Thiele <mi...@saxsys.de> ---
Created attachment 31417
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31417&action=edit
Example .war and maven projects for the META-INF/services caching problem

I have built a small example of what happens in our code.
Deployment in Tomcat 7.0.27 and 7.0.28 should render different results (time
needed is increased by factor 10 with META-INF/services) when accessing the
root path, e.g., http://localhost:8080/tomcat.caching-0.0.1-SNAPSHOT/.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56293] WebappClassLoader does not cache META-INF/services which leads to performance issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56293

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Neither the problem nor the solution appear to be that simple. Looking at the
ServiceLoader code, the contents of META-INF/services aren't read using the
method where the caching was removed.

Can you put together a simple test case that demonstrates this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org