You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/11/20 15:05:43 UTC
[GitHub] [incubator-livy] codecov-io commented on issue #165: [LIVY-581] Fix
edge-case where livy overrides user-provided spark properties instead of
appending
codecov-io commented on issue #165: [LIVY-581] Fix edge-case where livy overrides user-provided spark properties instead of appending
URL: https://github.com/apache/incubator-livy/pull/165#issuecomment-556043125
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/165?src=pr&el=h1) Report
> Merging [#165](https://codecov.io/gh/apache/incubator-livy/pull/165?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/6261c57be8df66d5f3fc3ccdaa15f8c4e1989d1d?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `37.93%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/165?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #165 +/- ##
============================================
- Coverage 67.85% 67.79% -0.06%
- Complexity 937 940 +3
============================================
Files 102 102
Lines 5876 5894 +18
Branches 891 896 +5
============================================
+ Hits 3987 3996 +9
- Misses 1315 1326 +11
+ Partials 574 572 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/165?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/165/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.11% <100%> (+0.09%)` | `21 <0> (ø)` | :arrow_down: |
| [...e/livy/server/interactive/InteractiveSession.scala](https://codecov.io/gh/apache/incubator-livy/pull/165/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uLnNjYWxh) | `66.76% <5.26%> (-2.61%)` | `46 <0> (ø)` | |
| [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/165/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `66.01% <0%> (-1.31%)` | `40% <0%> (ø)` | |
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/165/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `33.33% <0%> (+0.45%)` | `11% <0%> (ø)` | :arrow_down: |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/165/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.75% <0%> (+2.09%)` | `46% <0%> (+3%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/165?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/165?src=pr&el=footer). Last update [6261c57...2c1d172](https://codecov.io/gh/apache/incubator-livy/pull/165?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services